-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option for multiple views loading #197
base: main
Are you sure you want to change the base?
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a57287 - Browse repository at this point
Copy the full SHA 9a57287View commit details
Commits on May 31, 2024
-
Added example using
median_filter()
andsavgol_filter()
(neuroinf……ormatics-unit#193) * example usage for the median filter * formating and wording tweaks * make example titles and subtitles consistently imperative * finished first full draft of the example * added section about combining smoothing filters * ignore doi link during linkcheck * Apply suggestions from code review Co-authored-by: Chang Huan Lo <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix line lenghts * use px2 instead of dB --------- Co-authored-by: Chang Huan Lo <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0f2cd88 - Browse repository at this point
Copy the full SHA 0f2cd88View commit details
Commits on Jun 3, 2024
-
Refactored modules related to input-output (neuroinformatics-unit#194)
* added from_numpy() function to the load_poses module * unit test new function * use from_numpy() function in other loaders as well * add Examples section to docstring and render in API index * add Examples section to docstring and render in API index * confidence array is optional * None is the default for confidence * rename private functions * renamef from_dlc_df to from_dlc_style_df * harmonise docstrings in load_poses * harmonised function names and docstrings in save_poses * harmonised docstrings in validators * split Input/Output section of API index into modules * renamed `_from_lp_or_dlc_file` to `_ds_from_lp_or_dlc_file`
Configuration menu - View commit details
-
Copy full SHA for 8e20498 - Browse repository at this point
Copy the full SHA 8e20498View commit details -
[pre-commit.ci] pre-commit autoupdate (neuroinformatics-unit#202)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.3 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.3...v0.4.7) - [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 53a9eff - Browse repository at this point
Copy the full SHA 53a9effView commit details
Commits on Jun 6, 2024
-
Update supported Python versions (neuroinformatics-unit#208)
* bump python versions for PyPI and CI * recommend py3.11 for conda env during installation * display supported python versions as a shield in README * pyupgrade auto-update Union to | syntax
Configuration menu - View commit details
-
Copy full SHA for 52ac099 - Browse repository at this point
Copy the full SHA 52ac099View commit details
Commits on Jun 7, 2024
-
Accessor
compute_
to only validate requiredposition
data variable (neuroinformatics-unit#206) * Validate required dimensions only * Fix fstring Co-authored-by: Niko Sirmpilatze <[email protected]> * Update docstring --------- Co-authored-by: Niko Sirmpilatze <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a1c91e6 - Browse repository at this point
Copy the full SHA a1c91e6View commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cf0a6b1 - Browse repository at this point
Copy the full SHA cf0a6b1View commit details
Commits on Jun 12, 2024
-
Refactor validators (neuroinformatics-unit#204)
* Split validators into modules * Fix API index * Fix API reference * Fix docstring * Move validator module one level up
Configuration menu - View commit details
-
Copy full SHA for 0114b91 - Browse repository at this point
Copy the full SHA 0114b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for b123994 - Browse repository at this point
Copy the full SHA b123994View commit details -
Move logging.py inside utils (neuroinformatics-unit#216)
* move logging.py inside utils * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e4eea35 - Browse repository at this point
Copy the full SHA e4eea35View commit details
Commits on Jun 13, 2024
-
Add a ValidBboxesDataset class (neuroinformatics-unit#201)
* Skeleton for ValidBboxesDataset class * Add ID string format check * Print all IDs with wrong format * Check IDs are 1-based * Make ID list not optional * Add test for invalid centroid or shape arrays * Add test for invalid ID array * Fix confidence array setting to nan * Add test for confidence array * Add fixtures for valid bboxes arrays * move method to class * Add log message check to invalid_centroid_position_array test * Print attribute.name (rather than attribute) in error messages * Add log messages for shape_array tests * Add logs check for ID attribute * Fix log message * Add log message check to confidence array * Combine pattern matching tests * Change log messages in tests * Rename data array from centroid_position to position * Rename IDs to individual_names * Remove checks for position and shape arrays to be 3 dimensional * Remove enforcing IDs are 1-based in valid bbox class * Make individual_names optional and assign default value * Remove requirement (and test) for a indvidual_names to be in a specific format * Change validator and test to take individual_names as optional inputs * Add fixture request to confidence array test * Clean up * Clean up tests * Fix docstring * Small cosmetic edits * Add assert statement for default confidence matrix * Feedback from code review * Remove some comments * length of box --> extent * Refactor parameters into dict * Refactor as a function * Revert "Refactor as a function" This reverts commit 8056e28. * Clarify docstring for `individual_names` * Add feedback from code review
Configuration menu - View commit details
-
Copy full SHA for bba9403 - Browse repository at this point
Copy the full SHA bba9403View commit details
Commits on Jun 14, 2024
-
Refactor validators tests (neuroinformatics-unit#207)
* Split validators into modules * Split validators tests. Factor out long fixture. * Check log messages in tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add bboxes tests and put dataset fixtures in test file * Fix rebase side effect * Fix ky -> key --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bfe1640 - Browse repository at this point
Copy the full SHA bfe1640View commit details -
Update python version in README.md (neuroinformatics-unit#221)
Since [PR208](neuroinformatics-unit#208), python v3.11 is the main version we test across OSes and it's the one we recommend in the installation guide. But I'd forgotten to update the python version in the quick install section of the README. This PR rectifies that.
Configuration menu - View commit details
-
Copy full SHA for ba10263 - Browse repository at this point
Copy the full SHA ba10263View commit details
Commits on Jun 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2e406e1 - Browse repository at this point
Copy the full SHA 2e406e1View commit details
Commits on Jun 28, 2024
-
Add bboxes sample data (neuroinformatics-unit#231)
* Add "type" to sample datasets metadata, to include bbox data * rename pytest fixture POSE_DATA_PATHS to DATA_PATHS * Add 'type' to metadata required fields * Update docs * Apply suggestions from code review Co-authored-by: Chang Huan Lo <[email protected]> * Add platform specific tabs for computing hash * Remove pass for not implemented bit * pytest.DATA_PATHS refactor * Refactor `fetch_dataset_paths` * Update `sample_data` docstrings to accommodate bboxes data * Suggestion from code review * Remove if poses case for now, clarify TODO --------- Co-authored-by: Chang Huan Lo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f6553b - Browse repository at this point
Copy the full SHA 7f6553bView commit details
Commits on Jul 2, 2024
-
[pre-commit.ci] pre-commit autoupdate (neuroinformatics-unit#233)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.7 → v0.5.0](astral-sh/ruff-pre-commit@v0.4.7...v0.5.0) - [github.com/pre-commit/mirrors-mypy: v1.10.0 → v1.10.1](pre-commit/mirrors-mypy@v1.10.0...v1.10.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1f774ed - Browse repository at this point
Copy the full SHA 1f774edView commit details
Commits on Jul 3, 2024
-
Re-organise API reference (neuroinformatics-unit#213)
* API index just lists modules not single funcs * add customised jinja templated for sphinx-autosummary * Sanitise module-level docstrings * pre-commit applied * add modules rubric on api_index page * updated contributing guide section on API reference * monospace formating of attrs in module docstrings * Work around failing tests due to PR#231 * Hide attrs validator functions * Change class section "parameters" to "attributes" * Add MovementDataset class attributes docstrings * Revert "Work around failing tests due to PR#231" This reverts commit fe2c1c4. * Hide class method header if empty * Remove class attributes autosummary table * Remove extra space --------- Co-authored-by: lochhh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 43f17d7 - Browse repository at this point
Copy the full SHA 43f17d7View commit details
Commits on Jul 11, 2024
-
Make video download optional for sample datasets (neuroinformatics-un…
…it#224) * added optional video argument to sample data fetchers * renamed otpional arg to with_video * use the smaller Aeon video for testing video fetching * updated docs section on sample data * apply suggestions from review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b98cac0 - Browse repository at this point
Copy the full SHA b98cac0View commit details
Commits on Jul 17, 2024
-
Refactor
filtering
module to take DataArrays as input (neuroinforma……tics-unit#209) * Draft dataarray accessor * Move dataarray accessor methods to `filtering` * Add dataarray functions, test equality * Add tests * Add integration test * Remove filters taking Dataset as input * Reorganise filtering module * Update filter and smooth examples * Replace `window_length` with `window` * Format assert string * Remove old code accidentally reintroduced during rebase * Update docstrings * Add filtering methods to the `move` accessor * Add example to docstring * Remove obsolete and unused function imports * Move util functions to reports.py and logging.py * Apply suggestions from code review Co-authored-by: Niko Sirmpilatze <[email protected]> * Update docstrings * Add missing docstring * Add `move` accessor examples in docstrings * Remove `position` check in kinematics wrapper * Change`interpolate_over_time` to operate on num of observations * Add test for different `max_gap` values * Update `filter_and_interpolate.py` example * Fix `filtering_wrapper` bug * Update filter examples * Use dictionary `update` in `smooth` example * Move `logger` assignment to top of file * Add `update` example to "getting started" * Cover both dataarray and dataset in `test_log_to_attrs` * Test that ``log`` contains the filtering method applied * Use :py:meth: syntax for xarray.DataArray.squeeze() in examples * Update `reports.py` docstrings * Handle missing `individuals` and `keypoints` dims in NaN-reports * Return str in `report_nan_values` * Clean up examples * Convert filtering multiple data variables tip to section * Use `update()` in `filter_and_interpolate` example --------- Co-authored-by: Niko Sirmpilatze <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b27d7a2 - Browse repository at this point
Copy the full SHA b27d7a2View commit details
Commits on Jul 22, 2024
-
Add citation information (neuroinformatics-unit#240)
* Add zenodo badge and citation to readme * Create CITATION.CFF * Use full names * Add citation file to manifest * Add citation to website * updated citation.cff file after validation by cffinit * remove 2nd date from citation entry * homepage citation is included from README * added Sofia to pyproject.toml authors * harmonise spelling of my own name --------- Co-authored-by: niksirbi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 292a374 - Browse repository at this point
Copy the full SHA 292a374View commit details -
Small edits to ValidBboxesDataset (1/4) (neuroinformatics-unit#230)
* Add frame_array to ValidBboxesDataset * Edit log * Add test * Fix docstring * Add missing spaces in warning messages * Change default IDs to 0-based * Adapt sample_data tests to new metadata.yaml file in GIN repo * Refactor shape check * Suggestion for consistent names * Add attribute type * Check frames are contiguous * Add a column vector converter to frame_array * Revert "Add a column vector converter to frame_array" This reverts commit 3a99c1a.
Configuration menu - View commit details
-
Copy full SHA for 4830fd5 - Browse repository at this point
Copy the full SHA 4830fd5View commit details -
Add a ValidVIAtracksCSV class (2/4) (neuroinformatics-unit#219)
* Add skeleton for ValidVIAtracksCSV class * Add skeleton for ValidVIAtracksCSV test * Draft VIA file validator * Change asserts to errors (WIP) * Remove 1-based integer checks (for track ID and frames). Replace assert by errors * Small edits * Add tests for VIA file (pending fixtures) * Add one fixture * Add frame number as invalid file attribute * Factor out valid header fixture * Add test for frame number wrongly encoded in the filename * Add unique frame numbers test. Check bbox shape. * Add test for region attribute not defined * Add test for track ID not castable as an integer * Add test for unique track IDs per frame * Small edits to comments and docstrings * Apply suggestions from code review Co-authored-by: Niko Sirmpilatze <[email protected]> * Fix test duplicate from rebase * Rename symbols * csv to .csv * Small edits to comments --------- Co-authored-by: Niko Sirmpilatze <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 242f532 - Browse repository at this point
Copy the full SHA 242f532View commit details
Commits on Jul 30, 2024
-
Getting started docs update for bboxes (neuroinformatics-unit#245)
* Updates and suggestions to i/o docs section * Update input output with bboxes edits * Update dataset section with bboxes edits * Update sample data section with bboxes edits * pose --> poses datasets * Fix typo * Add from_numpy * Add example to export csv tracking data * Refer to _poses_ datasets in API reference for loading pose tracking data * Apply suggestions from code review Co-authored-by: Niko Sirmpilatze <[email protected]> * Add bboxes dataset to CONTRIBUTING.md * Clarify 2D poses in dataset docs * Add tabs and shape as code * Change shape formatting back * Fix `ds_type` comment * Add line with `to_dataframe` method * Replace assign_attrs by dict syntax --------- Co-authored-by: Niko Sirmpilatze <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d943b29 - Browse repository at this point
Copy the full SHA d943b29View commit details -
Auto-generate API index page (neuroinformatics-unit#234)
* Automate api_index.rst generation * Revert to using (updated) NIU build and publish docs actions * Include `make` commands in fancy tabs * Swap tab order * Mention index paths in the corresponding tabs
Configuration menu - View commit details
-
Copy full SHA for d10ec20 - Browse repository at this point
Copy the full SHA d10ec20View commit details
Commits on Jul 31, 2024
-
Load bboxes dataset from VIA tracks file (3/4) (neuroinformatics-unit…
…#229) * Draft load_bboxes.py * Keep dev notebook in history * Add df reformatting * Add extraction of arrays of expected shape * Some refactoring * From numpy array to xarray * Add test file * Remove dev notebook * Add "type" to sample datasets metadata, to include bbox data * Add sample data test * Docstrings and small refactoring * Add frame_array to ValidBbboxesDataset * Some cosmetic edits * test_fetch_dataset passes for bbox sample file * test_load_from_VIA_tracks_file passes * test_fps_and_time_coords passes * test_from_file_delegates_correctly passes * Move bboxes fixture out of conftest * test_from_numpy_valid passes * SImplify via_tracks_file fixture * Add test for via_attribute_column_to_numpy function * Apply docstring rephrasing suggestion Co-authored-by: Vasco Schiavo <[email protected]> * Make precommit happy * Add test to extract confidence function * Add test for extracting frame from via tracks df * refactor fixtures * Small edits and docstring review * Update API docs * Apply suggestions from code review Co-authored-by: Niko Sirmpilatze <[email protected]> * Fix rebase artifacts * Edits to docstrings for consistency * Modify `_via_attribute_column_to_numpy`, `_extract_frame_number_from_via_tracks_df` and `_extract_confidence_from_via_tracks_df` to return one-dimensional arrays instead of forcing always two-dimensional * Small edits to docstring & comments * Add "ds_type": "poses" to poses dataset * Make time origin at frame 0 == 0 seconds * Add load_bboxes to API index * Remove pass and refactor dataset fetching if bboxes * Fix test for time coordinates if fps passed * Add docstring examples to explain time origin * Add `use_frame_numbers_from_file` when loading a bboxes dataset from file or VIA tracks file * Add examples to docstrings of `use_frame_numbers_from_file` * Change default behaviour to not use frame numbers from file * Small edits to docstrings for doc building * Remove ignore comment * Update one-line summary of load_bboxes module for API reference * Update one-line summary of load_bboxes module for API reference * Fix backticks * Swap examples in docstrings * Delete API index * Fix from_file example --------- Co-authored-by: Vasco Schiavo <[email protected]> Co-authored-by: Niko Sirmpilatze <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 01c3cf6 - Browse repository at this point
Copy the full SHA 01c3cf6View commit details
Commits on Aug 1, 2024
-
Refactor names and fix docs formatting in
validators
(neuroinformat……ics-unit#251) * Fix indentation warnings * Use double backticks in docstrings * Fix indentation * Prepend _ to attrs validator functions in ValidVIATracksCSV to hide from API docs * Rename parameters --> attributes in docstring * Change path attr of ValidVIATracksCSV to be type pathlib.Path (consistency) * Add validation checks in the class-level docstring * Describe validation checks at dataset class-level * Shorten validator method names * Change ID to lowercase --------- Co-authored-by: sfmig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8e3ab99 - Browse repository at this point
Copy the full SHA 8e3ab99View commit details
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2122591 - Browse repository at this point
Copy the full SHA 2122591View commit details
Commits on Aug 7, 2024
-
Fix
tox requires
section (neuroinformatics-unit#261)* Fix tox requires section * Remove comment
Configuration menu - View commit details
-
Copy full SHA for 78b806e - Browse repository at this point
Copy the full SHA 78b806eView commit details -
[pre-commit.ci] pre-commit autoupdate (neuroinformatics-unit#258)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.5.6](astral-sh/ruff-pre-commit@v0.5.0...v0.5.6) - [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.1](pre-commit/mirrors-mypy@v1.10.1...v1.11.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1f219cb - Browse repository at this point
Copy the full SHA 1f219cbView commit details -
Adapt move accessor to bboxes datasets (neuroinformatics-unit#255)
* Add test for ds.move.validate() * Adapt move accessor to bboxes * Adapt tests to new conftest * Remove comments from conftest * Adapt kinematics tests * Adapt save poses tests * Adapt integration tests * Fix docstring * Remove unnecessary fixture from conftest.py for this PR * Refactor invalid poses datasets and exceptions * Add backticks and other small edits * Add test and fixture for bboxes dataset in seconds * Refactor `validate()` in `move_accessor` * Add missing blank line after block quote * Use lowercase in function and variable names * Remove duplicity * Remove sort in error message * Rename class attributes * Remove asserts * Rename function for consistency * Revert "Remove sort in error message" This reverts commit fab0bc6. * Suggestion to remove sorted * SImplify test parametrisation * Add invalid datasets with multiple dimensions on data vars missing * Remove whole-string check * Update `move_accessor.py` docstrings * Remove wrappers around `ds.rename` and `ds.drop_vars` in `conftest.py` --------- Co-authored-by: lochhh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c45183 - Browse repository at this point
Copy the full SHA 8c45183View commit details
Commits on Aug 8, 2024
-
Update setup docs (neuroinformatics-unit#264)
* Update python version in contributing guide * Add conda link to roadmap * Document conda installation * Update python version in `environment.yml` * Add conda update instructions * Suggestion nested tabs users / devs * Split install and update * Restructure installation guide * Recommend fresh env when updating --------- Co-authored-by: sfmig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e7ccfe5 - Browse repository at this point
Copy the full SHA e7ccfe5View commit details
Commits on Aug 13, 2024
-
Revert "Pin pandas version (& numpy) if python 3.12 (neuroinformatics…
…-unit#259)" (neuroinformatics-unit#272) This reverts commit 2122591.
Configuration menu - View commit details
-
Copy full SHA for 0cfded5 - Browse repository at this point
Copy the full SHA 0cfded5View commit details
Commits on Aug 14, 2024
-
Configure intersphinx (neuroinformatics-unit#269)
* Configure intersphinx * Document cross-referencing Python objects * Fix `interpolate_over_time` docstring * Restructure cross-referencing guide * Use simpler syntax for cross-referencing * Simplify cross-referencing guide * Link to internal references
Configuration menu - View commit details
-
Copy full SHA for d3fac95 - Browse repository at this point
Copy the full SHA d3fac95View commit details -
Suggestion to treat warnings as errors in sphinx-build (neuroinformat…
…ics-unit#256) * Stop sphinx-build on warning * Add clarification to workflow * Add flags to contributing guide * Remove comment in workflow file * Move flags to SPHINXOPTS
Configuration menu - View commit details
-
Copy full SHA for a17e099 - Browse repository at this point
Copy the full SHA a17e099View commit details
Commits on Aug 16, 2024
-
Refactor derivative (neuroinformatics-unit#270)
* Suggestion to rename internal method for clarity * Use `xr.DataArray.differentiate()` * Update docstrings --------- Co-authored-by: sfmig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9ba4302 - Browse repository at this point
Copy the full SHA 9ba4302View commit details -
Add utilities for vector magnitude and normalisation (neuroinformatic…
…s-unit#243) * added utility for vector magnitude * added utility for normalising vectors * use magnitude utility in kinematics example * use `magnitude` in `cart2pol` * reorder functions in vector.py * rename `magnitude` to `compute_norm` * define normalisation in polar coordinates too * Update comment phrasing Co-authored-by: sfmig <[email protected]> * generalise assertion about null vector normalisation * renamed `normalize` to `convert_to_unit` * extend test for conversion to unit vectors * refactor erro raising into separate func --------- Co-authored-by: sfmig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 96c3cd7 - Browse repository at this point
Copy the full SHA 96c3cd7View commit details -
Simplify and expand filtering tests for bboxes (neuroinformatics-unit…
…#267) * Extend filtering tests * Fix docstrings for test cases * Review docstrings for bboxes references * Move dict definition * Fix time unit odd scaling
Configuration menu - View commit details
-
Copy full SHA for abeaff1 - Browse repository at this point
Copy the full SHA abeaff1View commit details
Commits on Aug 22, 2024
-
Update test_and_deploy.yml (neuroinformatics-unit#275)
Add `nodefaults` channel to prevent from using the `defaults` channel. See [docs](https://docs.conda.io/projects/conda/en/4.6.1/user-guide/tasks/manage-environments.html#:~:text=You%20can%20exclude%20the%20default%20channels%20by%20adding%20nodefaults%20to%20the%20channels%20list.)
Configuration menu - View commit details
-
Copy full SHA for 38246d9 - Browse repository at this point
Copy the full SHA 38246d9View commit details
Commits on Aug 27, 2024
-
Extend tests for bboxes datasets (neuroinformatics-unit#246)
* Add valid_bboxes_dataset fixture * Change keys in valid bboxes fixtures * Parametrize test_filter_by_confidence to include both types of datasets (WIP) * Parametrize tests for move accessor with valid datasets to include bboxes * Remove class for move accessor tests (suggestion) * Add valid bboxes dataset to kinematic tests (WIP) * Rename valid_bboxes_arrays for testing shape only * Define a realistic valid_bboxes_dataset * Extend move accessor tests to invalid bboxes datasets * Extend test filter by confidence to bboxes * Extend test_interpolate_over_time to bboxes datasets * Extend test_median_filter * Extend tests for median filter * Fix save_poses tests (adapt to new invalid dataset fixtures) * Fix kinematics tests for poses datasets (adapt to new fixture for invalid datasets) * Fix kinematics integration tests for invalid poses datasets * Extend test_reports to bboxes dataset and make report check explicit * Expand test_log_to_attrs to bboxes * Extend savgol basic test to bboxes * Extend test_savgol_filter_kwargs_override to bboxes * Extend test_savgol_filter_with_nans to bboxes * Edit test names * Prep extending kinematics (WIP) * Reduce duplication in filtering tests * Make sonarcloud happy * Reduce duplication (hopefully) * Combine median and savgol filter tests * Fix merge artifacts * Refactor filtering tests * Simplify and expand kinematic tests * Suggestion to rename internal method for clarity * Review of test_vectors (WIP) * Remove changes in vector tests (in separate PR) * Apply suggestions from code review Co-authored-by: Niko Sirmpilatze <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove duplicate line * Suggestions from code review * Change order of comments in multiline fixtures * Fix parameterised fixture comments --------- Co-authored-by: Niko Sirmpilatze <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3ee5836 - Browse repository at this point
Copy the full SHA 3ee5836View commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3df12a9 - Browse repository at this point
Copy the full SHA 3df12a9View commit details
Commits on Aug 29, 2024
-
added new movement datasets figure, with caption (neuroinformatics-un…
…it#286) * added new movement datasets figure, with caption * update caption according to review comment --------- Co-authored-by: sfmig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9612951 - Browse repository at this point
Copy the full SHA 9612951View commit details -
Configuration menu - View commit details
-
Copy full SHA for f47d6e7 - Browse repository at this point
Copy the full SHA f47d6e7View commit details
Commits on Sep 3, 2024
-
[pre-commit.ci] pre-commit autoupdate (neuroinformatics-unit#296)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.6 → v0.6.3](astral-sh/ruff-pre-commit@v0.5.6...v0.6.3) - [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a98ff45 - Browse repository at this point
Copy the full SHA a98ff45View commit details
Commits on Sep 6, 2024
-
Simplify and expand kinematic tests for bboxes (neuroinformatics-unit…
…#265) * Simplify and expand kinematic tests * Suggestion to rename internal method for clarity * Update docstrings for API reference docs * Add test for values * Refactor test for uniform linear motion * Add notes to dosctrings * Fix kinematics tests * Add fixture with uniform linear motion for poses * Add poses dataset to linear uniform motion test * Add test for dataset with nans * Edits to docstrings * Remove circular fixture * Small edits to fixture comments * Edits to comments in tests * Small edits * Clarify vector vs array in docstrings and make consistent where required * Add missing docstring in test and small edits * Remove TODOs * Fix offset in fixture for uniform linear motion poses * Apply suggestions from code review Co-authored-by: Chang Huan Lo <[email protected]> * Differentiation method Co-authored-by: Chang Huan Lo <[email protected]> * Docstrings fixes * :py:meth: to :meth: * Combine into one paragraph * Add uniform linear motion to doscstring of fixtures * Simplify valid_poses_array_uniform_linear_motion with suggestions * kinematic_variable --> kinematic_array * Simplify test_kinematics_uniform_linear_motion with suggestion from review * Update tests/test_unit/test_kinematics.py Co-authored-by: Chang Huan Lo <[email protected]> * Update tests/test_unit/test_kinematics.py Co-authored-by: Chang Huan Lo <[email protected]> * Cosmetic edits to test * Change docstring to time-derivative --------- Co-authored-by: Chang Huan Lo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 95965f8 - Browse repository at this point
Copy the full SHA 95965f8View commit details -
Fix xarray FutureWarning about dims vs sizes (neuroinformatics-unit#297)
* use ds.sizes insted of ds.dims * Change .dims to .sizes in kinematics tests --------- Co-authored-by: sfmig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f4f46df - Browse repository at this point
Copy the full SHA f4f46dfView commit details
Commits on Sep 13, 2024
-
Add bbox centroid fix (neuroinformatics-unit#303)
* Add bbox centroid fix * Add tests * Remove loop from assert * Clarify docstring * Remove spaces * Update tests/test_unit/test_load_bboxes.py Co-authored-by: Niko Sirmpilatze <[email protected]> --------- Co-authored-by: Niko Sirmpilatze <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 644c1b1 - Browse repository at this point
Copy the full SHA 644c1b1View commit details
Commits on Sep 17, 2024
-
General validator function for checking dimensions and coordinates (n…
…euroinformatics-unit#294) * replace time dim validator with more generic validator * constrain kinematic functions to cartesian coordinates * renamed new validator to validate_dims_coords * add examples in validator docstring * unit tests for the new validator * Apply suggestions from code review do note validate x,y space coordinates specifically. Co-authored-by: Chang Huan Lo <[email protected]> * reuse fixture valid_poses_dataset_uniform_linear_motion * combine two unit tests into one * expose public `compute_time_derivative` function * Refactor test * Update refs to `compute_time_derivative` --------- Co-authored-by: Chang Huan Lo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9c80786 - Browse repository at this point
Copy the full SHA 9c80786View commit details
Commits on Oct 4, 2024
-
Compute Forward Vector (neuroinformatics-unit#276)
* Basic implementation of `compute_head_direction_vector()` * Minor fixes docstring * Added unit test for `compute_head_direction_vector()` * Bug fixes for `test_compute_head_direction_vector()` * Added validator (and test) to ensure input is 2D * Refactored `navigation.py` and implemented PR review feedback * Extended testing and added `front_keypoint` argument to `compute_head_direction_vector()` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Implemented PR feedback and bugfixes for `compute_2d_head_direction_vector()` * Removed uppercase letters from function names * Tweaked `compute_polar_coordinates.py` to use new function * Implemented feedback from Zulip discussion and created `compute_head_direction_vector()` alias function * Fixed typo in docstring * Tweaked `compute_forward_vector()` to use new validator * More fixes for `test_kinematics.py` * Bugfix for `compute_forward_vector()` and expanded `test_compute_forward_vector` to cover both `camera_view` options * Added test coverage for `compute_head_direction_vector()` alias * Reversed changes to `compute_polar_coordinates.py` and implemented final feedback --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a6dc15e - Browse repository at this point
Copy the full SHA a6dc15eView commit details
Commits on Oct 8, 2024
-
[pre-commit.ci] pre-commit autoupdate (neuroinformatics-unit#318)
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/astral-sh/ruff-pre-commit: v0.6.3 → v0.6.9](astral-sh/ruff-pre-commit@v0.6.3...v0.6.9) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bfb20d2 - Browse repository at this point
Copy the full SHA bfb20d2View commit details
Commits on Oct 17, 2024
-
Update integration tests (neuroinformatics-unit#295)
* Add filter with nan under threshold and varying window * Get kinematics tests * Adapt integration tests for kinematics+polar * Update integration tests for filtering * Fix factor 2 difference * Update conftest * Remove redundant comment in conftest * Apply feedback from kinematic tests * Cosmetic changes * Spoof user-agent to avoid 403 error * Check different URL * Ignore link to license temporarily * Try fake-useragent * Revert "Try fake-useragent" This reverts commit d67de0e.
Configuration menu - View commit details
-
Copy full SHA for a42838d - Browse repository at this point
Copy the full SHA a42838dView commit details -
Fix command for installation of docs dependencies in the guide. (neur…
…oinformatics-unit#323) * Change command for installation of docs dependencies in the guide. * Small edits to phrasing * Move environment creation to the top of the section * Combine all dependencies installations
Configuration menu - View commit details
-
Copy full SHA for b399ce0 - Browse repository at this point
Copy the full SHA b399ce0View commit details
Commits on Oct 22, 2024
-
Add example to convert file formats and changing keypoints (neuroinfo…
…rmatics-unit#304) * first draft of example to convert file formats and changing keypoints * second draft to convert and modify pose track files. I split the function into three separate operations. * formatted the code and gotrid of spelling mistakes for the docs * changed outline of code, new functions now handle ds not fpaths and added additional example function to run on fpath * Apply suggestions from code review added Niko's suggestions, implementing comments Co-authored-by: Niko Sirmpilatze <[email protected]> * pre-commit changes * corrected import error * pre-commit changes again * get rid of extra underlines * finishing touches * added default thumbnail for examples without plots --------- Co-authored-by: Niko Sirmpilatze <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6c32608 - Browse repository at this point
Copy the full SHA 6c32608View commit details
Commits on Oct 24, 2024
-
Drop the
.move
accessor (neuroinformatics-unit#322)* replace accessor with MovementDataset dataclass * moved pre-save validations inside save_poses module * deleted accessor code and associated tests * define dataset structure in modular classes * updated stale docstring for _validate_dataset() * remove mentions of the accessor from the getting started guide * dropped accessor use in examples * ignore linkcheck for opensource licenses * Revert "ignore linkcheck for opensource licenses" This reverts commit c8f3498. * use ds.sizes instead of ds.dims to suppress warning * Add references * remove movement_dataset.py module --------- Co-authored-by: lochhh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f7f3b48 - Browse repository at this point
Copy the full SHA f7f3b48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b6b44d - Browse repository at this point
Copy the full SHA 1b6b44dView commit details
Commits on Oct 25, 2024
-
Refactor auto-generate API docs (neuroinformatics-unit#331)
* Add `clean` action to Windows `make` file * Use `fail-on-warning` mode in Windows `make` file * Drop unused `--keep-going` flag in Makefile * Refactor auto-generate api docs * Update contributing docs * Remove Sphinx version constraint * Document make-mode only * Allow target chaining in Windows make
Configuration menu - View commit details
-
Copy full SHA for 7813e7c - Browse repository at this point
Copy the full SHA 7813e7cView commit details
Commits on Oct 29, 2024
-
Encourage R users to check out
animovement
(neuroinformatics-unit#335)* added tip for R users * added script for converting admonitions to myst * refactored conversion script
Configuration menu - View commit details
-
Copy full SHA for b10896f - Browse repository at this point
Copy the full SHA b10896fView commit details -
Compute pairwise distances (neuroinformatics-unit#278)
* Draft inter-individual distances * Return vector norm in `compute_interindividual_distances` * Add `compute_interkeypoint_distances` * Refactor pairwise distances tests * Use `scipy.spatial.distance.cdist` * Add examples to docstrings * Rename variables * Update test function args + fix indentation * Handle scalar and 1d dims * Handle missing `core_dim` * Refactor `cdist` and tests * Fix docstrings * Reorder functions + cleanup docs * Reduce pairwise distances functions * Mention examples of available distance metrics * Update docstrings * Require `pairs` in `compute_pairwise_distances` * Raise error if there are no pairs to compute distances for * Rename `core_dim` to `labels_dim` * Spell out expected pairs in test * Merge old `kinematics` file changes into new * Rename `core_dim` to `labels_dim` in tests * Validate dims in `compute_pairwise_distances` * Apply suggestions from code review Co-authored-by: Niko Sirmpilatze <[email protected]> * Apply suggestions from code review Co-authored-by: Niko Sirmpilatze <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Niko Sirmpilatze <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 536de0e - Browse repository at this point
Copy the full SHA 536de0eView commit details
Commits on Nov 4, 2024
-
[pre-commit.ci] pre-commit autoupdate (neuroinformatics-unit#338)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.9 → v0.7.2](astral-sh/ruff-pre-commit@v0.6.9...v0.7.2) - [github.com/pre-commit/mirrors-mypy: v1.11.2 → v1.13.0](pre-commit/mirrors-mypy@v1.11.2...v1.13.0) - [github.com/mgedmin/check-manifest: 0.49 → 0.50](mgedmin/check-manifest@0.49...0.50) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ca4daf2 - Browse repository at this point
Copy the full SHA ca4daf2View commit details
Commits on Nov 5, 2024
-
Implement
compute_speed
andcompute_path_length
(neuroinformatics……-unit#280) * implement compute_speed and compute_path_length functions * added speed to existing kinematics unit test * rewrote compute_path_length with various nan policies * unit test compute_path_length across time ranges * fixed and refactor compute_path_length and its tests * fixed docstring for compute_path_length * Accept suggestion on docstring wording Co-authored-by: Chang Huan Lo <[email protected]> * Remove print statement from test Co-authored-by: Chang Huan Lo <[email protected]> * Ensure nan report is printed Co-authored-by: Chang Huan Lo <[email protected]> * adapt warning message match in test * change 'any' to 'all' * uniform wording across path length docstrings * (mostly) leave time range validation to xarray slice * refactored parameters for test across time ranges * simplified test for path lenght with nans * replace drop policy with ffill * remove B905 ruff rule * make pre-commit happy --------- Co-authored-by: Chang Huan Lo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a3956c4 - Browse repository at this point
Copy the full SHA a3956c4View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5626ef3 - Browse repository at this point
Copy the full SHA 5626ef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21fdd2a - Browse repository at this point
Copy the full SHA 21fdd2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 087ba66 - Browse repository at this point
Copy the full SHA 087ba66View commit details -
Merge remote-tracking branch 'origin/load-multiview' into load-multiview
# Conflicts: # movement/io/load_poses.py # tests/test_unit/test_kinematics.py # tests/test_unit/test_load_poses.py
Configuration menu - View commit details
-
Copy full SHA for a669338 - Browse repository at this point
Copy the full SHA a669338View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab62209 - Browse repository at this point
Copy the full SHA ab62209View commit details