Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs based on my "experiences" this week #51

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Feb 23, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
I messed up and unintentionally deleted some user data this week.
This was because I mounted the same drive on two different folders (/media/something/ and /mnt/something/) and then decided I didn't want that. So I did sudo rm -r /mnt/something/ and started deleting files. I immediately realised and hit Ctrl+C but it was too late to prevent file loss entirely (at least only some files were deleted). Luckily looks like it's recoverable... 😅

What does this PR do?
Adds a warning to the mounting instructions.

@alessandrofelder alessandrofelder marked this pull request as ready for review February 23, 2024 10:58
@alessandrofelder alessandrofelder requested a review from a team February 23, 2024 10:58
Copy link
Collaborator

@sfmig sfmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! a small suggestion, but feel free to ignore if you have strong feelings against it

docs/source/programming/Mount-ceph-ubuntu-temp.md Outdated Show resolved Hide resolved
@@ -73,3 +73,7 @@ The next time you reboot your machine, the storage should be mounted automatical
To unmount the storage, run `sudo umount /media/ceph-neuroinformatics` (or whatever your mount point is).

To permanently unmount the storage, remove the lines you added to the `fstab` file and run `sudo mount -a` again.

:::{warning}
Do not trust your instincts and use `sudo rm -r /media/ceph-neuroinformatics` to permanently unmount, even though it looks like a local folder. This will delete files on `ceph`!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Do not trust your instincts and use `sudo rm -r /media/ceph-neuroinformatics` to permanently unmount, even though it looks like a local folder. This will delete files on `ceph`!
Do not use `sudo rm -r /media/ceph-neuroinformatics` to permanently unmount, even though it looks like a local folder. This will delete files on `ceph`!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@alessandrofelder alessandrofelder merged commit dce09e6 into main Feb 23, 2024
3 checks passed
@alessandrofelder alessandrofelder deleted the alessandro-lessons-learned branch February 23, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants