[FIX] [WIP] NOT READY YEY #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remi-Gau
commented
Jun 26, 2024
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install .[dev] |
There was a problem hiding this comment.
there is no dev in the pyproject.toml
Remi-Gau
commented
Jun 26, 2024
| @@ -30,13 +30,5 @@ jobs: | |||
| - name: Install | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install -e .[tests] | |||
| - name: Run tests and coverage | |||
| run: make coverage | |||
Remi-Gau
commented
Jun 26, 2024
| hooks: | ||
| - id: auto-walrus | ||
| # Sorts Python imports alphabetically and by section with `isort`. | ||
| - repo: https://github.com/pycqa/isort |
There was a problem hiding this comment.
isort is more common than reorder-python-imports
may be less confusing for other pythonistas
Remi-Gau
commented
Jun 26, 2024
|
|
||
| - repo: https://github.com/jumanjihouse/pre-commit-hook-yamlfmt | ||
| rev: 0.2.3 | ||
| hooks: | ||
| - id: yamlfmt | ||
| args: [--mapping, '2', --sequence, '2', --offset, '0'] | ||
|
|
||
| # Format TOML files | ||
| - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks |
There was a problem hiding this comment.
just to keep your pyproject.toml organized
Remi-Gau
commented
Jun 26, 2024
| license = { file = "LICENSE.txt" } | ||
| authors = [{ name = "James Randolph", email = "[email protected]" }] | ||
| dynamic = ["version"] | ||
| dependencies = ["langchain", "langchain_core", "langchain_community"] |
There was a problem hiding this comment.
you were missing some dependencies that will be needed for testing
Remi-Gau
commented
Jun 26, 2024
Comment on lines
+39
to
+42
| version-file = "src/loxlm/_version.py" | ||
|
|
||
| [tool.pytest.ini_options] | ||
| addopts = "-ra -vv" | ||
| [tool.hatch.build.targets.wheel] | ||
| packages = ["src/loxlm"] |
There was a problem hiding this comment.
adapted some paths to match the packaging
Remi-Gau
commented
Jun 26, 2024
| @@ -2,30 +2,25 @@ | |||
|
|
|||
| import json | |||
|
|
|||
| from langchain.agents import AgentExecutor | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.