Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DF-795: FIX for data attributes #1278

Merged
merged 2 commits into from
Aug 23, 2023
Merged

DF-795: FIX for data attributes #1278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
531a79d
Remove old attributes
jamesbiggs Aug 23, 2023
9995e55
Make forloop counter start from 0
jamesbiggs Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/includes/card-group-record-summary-no-image.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<li class="col-sm-12 col-md-6 col-lg-4">
<div class="card-group-record-summary">
<a href="{% if url %}{{ url }}{% else %}{% record_url record is_editorial=True %}{% endif %}" class="card-group-record-summary__link" data-link="{{ record.summary_title }}" data-position="{{ forloop.counter }}" heldBy="{% if record.held_by %}{{ record.held_by }}{% else %}None{% endif %}" data-card-type="card-group-record-summary-no-image" data-card-title="{% firstof description_override|safe record.summary_title %}"{% if FEATURE_RECORD_LINKS_GO_TO_DISCOVERY %} target="_blank"{% endif %}>
<a href="{% if url %}{{ url }}{% else %}{% record_url record is_editorial=True %}{% endif %}" class="card-group-record-summary__link" data-link="{{ record.summary_title }}" data-position="{{ forloop.counter0 }}" heldBy="{% if record.held_by %}{{ record.held_by }}{% else %}None{% endif %}" {% if FEATURE_RECORD_LINKS_GO_TO_DISCOVERY %} target="_blank"{% endif %}>
<p class="card-group-record-summary__heading">
{% if record.reference_number %}
<span class="sr-only">
Expand Down
Loading