Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DF-795: FIX for data attributes #1278

Merged
merged 2 commits into from
Aug 23, 2023
Merged

DF-795: FIX for data attributes #1278

merged 2 commits into from
Aug 23, 2023

Conversation

jamesbiggs
Copy link
Collaborator

@jamesbiggs jamesbiggs commented Aug 23, 2023 •
edited by jira bot
Loading

Ticket URL: DF-795

About these changes

Made for loop start from 0, and removed pre-existing data attributes

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer.
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
  • Ensured that PR includes only commits relevant to the ticket.
  • Waited for all CI jobs to pass before requesting a review.
  • Added/updated tests and documentation where relevant.

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs added the finding Work relating to the Finding team label Aug 23, 2023
@jamesbiggs jamesbiggs changed the title DF-795: FIX for data attributes DF-759: FIX for data attributes Aug 23, 2023
@jamesbiggs jamesbiggs changed the title DF-759: FIX for data attributes DF-795: FIX for data attributes Aug 23, 2023
JohnHeeryTNA
JohnHeeryTNA approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@JohnHeeryTNA JohnHeeryTNA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving change

@jamesbiggs jamesbiggs merged commit af464cf into develop Aug 23, 2023
8 checks passed
@jamesbiggs jamesbiggs deleted the fix/DF-795 branch August 23, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnHeeryTNA JohnHeeryTNA JohnHeeryTNA approved these changes

Assignees
No one assigned
Labels
finding Work relating to the Finding team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbiggs @JohnHeeryTNA