fix remove_items_in_codeblocks regex for codeblocks nested in lists #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdevalias
added a commit
to 0xdevalias/chatgpt-source-watch
that referenced
this pull request
Jan 18, 2024
0xdevalias
added a commit
to 0xdevalias/chatgpt-source-watch
that referenced
this pull request
Jan 19, 2024
|
@naokazuterada Any chance of getting this reviewed/merged/released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex within
remove_items_in_codeblockdoesn't properly match codeblocks nested inlists, which results in invalid ToC generation (often meaning large chunks of actual content get incorrectly filtered out due to bad matching between opening/closing code fence backticks)This PR fixes the regex so that it will correctly match when a codeblock is nested in a list started with
-or*.