Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve handling for code blocks nested in lists #26

Closed
0xdevalias opened this issue Jan 18, 2024 · 1 comment · Fixed by #29
Closed

Further improve handling for code blocks nested in lists #26

0xdevalias opened this issue Jan 18, 2024 · 1 comment · Fixed by #29

Comments

@0xdevalias
Copy link
Contributor

I see that better support for code blocks nested in lists was added in this commit:

But if I am reading it correctly, I believe those changes still won't work properly in the case of a code block nested in a list on the same line (which is valid in GitHub Flavoured markdown, and maybe others)

eg.

- This is a list
- It has items
  - ```js
    console.log("Foo")
    ```

See also:

0xdevalias added a commit to 0xdevalias/chatgpt-source-watch that referenced this issue Jan 18, 2024
0xdevalias added a commit to 0xdevalias/chatgpt-source-watch that referenced this issue Jan 19, 2024
@derlin
Copy link
Owner

derlin commented Mar 6, 2024

This is a very good point, thanks for letting me know! I will try to work on this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants