Little refactorings for tutorial.js #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix increments the step number of the nextStepButton to the next step number, so the loadTutorialStep() function just has to call this step number without incrementation.
…torialStep() function
This change moves the changeListener for the ACE editor from the handle EditorChanges() function to the loadTutorialStep() function. Thus it avoids the necessity to stop change propagation and recursive call. It also removes some unnecessary parameters from handleEditorChanges() as well as it simplifies the mechanism to disallow/allow download and/or continuation with next step.
…ered As mentioned by @KristinaRichts and @krHERO , the current error message when an encoding cannot be rendered in the tutorials was misleading ("Please adjust your encoding …").
This change adds a console log for any NaN values to improve debugging of music-encoding#136.
…ng of loadTutorialStep
|
@KristinaRichts @krHERO |
|
@KristinaRichts and @krHERO any chance you have a look at this? |
|
I also think, that the error message you suggested is better than the previous one, but in the long run, the reactions should be so clear that the user can understand why the coding cannot be rendered. |
|
thx @krHERO and @KristinaRichts merged for now and noted for future improvement in #150 |
bwbohl
added a commit
that referenced
this pull request
May 9, 2022
Little refactorings for tutorial.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some light refactorings for tutorials.js, including
It also adds another log if a stepNumber is thrown with a value of NaN to improve debugging of #136 .