Skip to content

Commit

Permalink
fix(tutorials.js): improve error message when encoding cannot be rend…
Browse files Browse the repository at this point in the history
…ered

As mentioned by @KristinaRichts and @krHERO ,
the current error message when an encoding cannot be rendered in the tutorials
was misleading ("Please adjust your encoding …").
  • Loading branch information
musicEnfanthen committed Jun 18, 2020
1 parent 8cda242 commit 9333d9e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/mei-tutorials.js
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ function renderVerovio(validationString) {

if (error) {
// display message
document.getElementById('rendering').innerHTML = 'please adjust encoding to enable rendering';
document.getElementById('rendering').innerHTML = 'The current encoding cannot be rendered.';
} else {
// display svg
document.getElementById('rendering').innerHTML = svg;
Expand Down

1 comment on commit 9333d9e

@krHERO
Copy link
Contributor

@krHERO krHERO commented on 9333d9e Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now i would agree on this solution, since it is better than the current message shown.
but i am not perfectly happy with it (reasons where already mentioned by @musicEnfanthen). sections in the tutorial dealing with structural elements or metadata information need no comment about rendering at all. while the comment "please adjust enconding ..." is/was very helpful for sections dealing with musical encoding.

Please sign in to comment.