Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks to merge before the workshop #117

Merged
merged 9 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@ docs
*.gcov
.valgrind_ignore
inst/doc
pkgdown
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: odin2
Title: Next generation odin
Version: 0.2.13
Version: 0.3.0
Authors@R: c(person("Rich", "FitzJohn", role = c("aut", "cre"),
email = "[email protected]"),
person("Wes", "Hinsley", role = "aut"),
Expand All @@ -17,9 +17,9 @@ URL: https://mrc-ide.github.io/odin2, https://github.com/mrc-ide/odin2
BugReports: https://github.com/mrc-ide/odin2/issues
Imports:
cli,
dust2 (>= 0.2.1),
dust2 (>= 0.3.0),
glue,
monty (>= 0.2.39),
monty (>= 0.3.0),
rlang
Suggests:
decor,
Expand Down
3 changes: 2 additions & 1 deletion R/migrate.R
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ odin_migrate <- function(path, dest) {
"{cli::qty(sum(is_error))}{?This statement has/These statements have}",
"been preserved in the migrated code at '{dest}'"))
cli::cli_alert_info(
"See {.vignette migrating} for information on updating these issues")
paste("See {.vignette odin2::migrating} for information on updating",
"these issues"))
}

if (!any(is_migratable) && identical(path, dest)) {
Expand Down
8 changes: 4 additions & 4 deletions R/parse_compat.R
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ parse_compat_fix_assign_time <- function(expr, call) {
x = paste(
"Your code contains an assignment to 'time' that we can't",
"automatically migrate"),
i = "Please see {.vignette migrating} for guidance"),
i = "Please see {.vignette odin2::migrating} for guidance"),
"E1048", expr, call)
}
}
Expand All @@ -313,11 +313,11 @@ parse_compat_fix_assign_dt <- function(expr, call) {
## might look. For now, this is not allowed.
odin_parse_error(
c("Don't assign to 'dt'",
i = "'dt' is now provided to {.help dust::dust_system_create}'",
i = "'dt' is now provided to {.fun dust2::dust_system_create}'",
x = paste(
"Your odin code contains an assignment to 'dt' that we can't",
"automatically migrate"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below - {.vignette migrating} sadly seems not clickable in RStudio (red no entry icon).
Changing to {.vignette odin2::migrating} makes it clickable, but then gives
Error: vignette ‘migrating’ not found - I will play some more

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works if you install from r-universe it seems

i = "Please see {.vignette migrating} for guidance"),
i = "Please see {.vignette odin2::migrating} for guidance"),
"E1049", expr, call)
}
}
Expand Down Expand Up @@ -345,7 +345,7 @@ parse_compat_fix_use_step <- function(expr, call) {
c("Use of 'step' is no longer allowed",
i = paste("Previously, discrete-time models used 'step' as a measure",
"of time, but we have removed this in odin2"),
i = "Please see {.vignette migrating} for guidance"),
i = "Please see {.vignette odin2::migrating} for guidance"),
"E1050", expr, call)
}
expr
Expand Down
2 changes: 1 addition & 1 deletion R/parse_system.R
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ parse_system_overall <- function(exprs, call) {
c("Can't use 'output()' in discrete time systems",
i = paste("You should be able to do what you need using 'update()'.",
"If you are migrating from odin 1.x.x, you might find",
'some advice in {.vignette "migrating"}')),
'some advice in {.vignette odin2::migrating}')),
"E2020", src, call)
}

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# odin2 <img src='man/figures/logo.png' align="right" height="139" />
# odin2 <a href="https://mrc-ide.github.io/odin2/"><img src="man/figures/logo.png" align="right" height="139" alt="odin2 website" /></a>

<!-- badges: start -->
[![Project Status: ConceptMinimal or no implementation has been done yet, or the repository is only intended to be a limited example, demo, or proof-of-concept.](https://www.repostatus.org/badges/latest/concept.svg)](https://www.repostatus.org/#concept)
[![Project Status: WIPInitial development is in progress, but there has not yet been a stable, usable release suitable for the public.](https://www.repostatus.org/badges/latest/wip.svg)](https://www.repostatus.org/#wip)
[![R build status](https://github.com/mrc-ide/odin2/workflows/R-CMD-check/badge.svg)](https://github.com/mrc-ide/odin2/actions)
[![codecov.io](https://codecov.io/github/mrc-ide/odin2/coverage.svg?branch=main)](https://codecov.io/github/mrc-ide/odin2?branch=main)
<!-- badges: end -->
Expand Down
Binary file added pkgdown/favicon/apple-touch-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pkgdown/favicon/favicon-96x96.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pkgdown/favicon/favicon.ico
Binary file not shown.
3 changes: 3 additions & 0 deletions pkgdown/favicon/favicon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions pkgdown/favicon/site.webmanifest
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "",
"short_name": "",
"icons": [
{
"src": "/web-app-manifest-192x192.png",
"sizes": "192x192",
"type": "image/png",
"purpose": "maskable"
},
{
"src": "/web-app-manifest-512x512.png",
"sizes": "512x512",
"type": "image/png",
"purpose": "maskable"
}
],
"theme_color": "#ffffff",
"background_color": "#ffffff",
"display": "standalone"
}
Binary file added pkgdown/favicon/web-app-manifest-192x192.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pkgdown/favicon/web-app-manifest-512x512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading