Small tweaks to merge before the workshop #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richfitz
commented
Nov 14, 2024
richfitz
commented
- Same fix for help
- Spelling errors
- Build favicon
- Eventually update version to 0.3.0 (small change now to avoid conflicts at each rebase)
weshinsley
reviewed
Nov 14, 2024
| @@ -313,7 +313,7 @@ parse_compat_fix_assign_dt <- function(expr, call) { | |||
| ## might look. For now, this is not allowed. | |||
| odin_parse_error( | |||
| c("Don't assign to 'dt'", | |||
| i = "'dt' is now provided to {.help dust::dust_system_create}'", | |||
| i = "'dt' is now provided to {.fun dust::dust_system_create}'", | |||
| x = paste( | |||
| "Your odin code contains an assignment to 'dt' that we can't", | |||
| "automatically migrate"), | |||
There was a problem hiding this comment.
Below - {.vignette migrating} sadly seems not clickable in RStudio (red no entry icon).
Changing to {.vignette odin2::migrating} makes it clickable, but then gives
Error: vignette ‘migrating’ not found - I will play some more
There was a problem hiding this comment.
it works if you install from r-universe it seems
weshinsley
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.