Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ansible interpreter #32

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tasks/main.yml
Original file line number Diff line number Diff line change
@@ -248,3 +248,8 @@
- result_accountkey.key_is_consistent
- result_csr.signature_valid
msg: "The private keys and CSR are valid"

- name: "Revert python interpreter"
set_fact:
ansible_python_interpreter: "{{ ansible_facts['discovered_interpreter_python'] }}"
when: revert_python_interpreter is defined and revert_python_interpreter == true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing the when condition to when: ansible_os_family in ['RedHat', 'Darwin'] to match the when condition for when the virtualenv tasks are executed? That way, we don't need to use a custom fact.

6 changes: 6 additions & 0 deletions tasks/virtualenv.yml
Original file line number Diff line number Diff line change
@@ -42,6 +42,12 @@
tags:
- install

- name: Set python interpreter revert flag
set_fact:
revert_python_interpreter: true
tags:
- install

- name: use the created virtualenv
set_fact:
ansible_python_interpreter: "{{ ler53_account_key_dir }}/ansible-lets-encrypt-virtualenv/bin/python"