Revert ansible interpreter #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoenberger
approved these changes
Apr 19, 2021
mprahl
reviewed
Jul 25, 2021
| - name: "Revert python interpreter" | ||
| set_fact: | ||
| ansible_python_interpreter: "{{ ansible_facts['discovered_interpreter_python'] }}" | ||
| when: revert_python_interpreter is defined and revert_python_interpreter == true |
There was a problem hiding this comment.
How about changing the when condition to when: ansible_os_family in ['RedHat', 'Darwin'] to match the when condition for when the virtualenv tasks are executed? That way, we don't need to use a custom fact.
mprahl
reviewed
Jul 25, 2021
| @@ -33,7 +33,7 @@ | |||
| - name: setuptools>44.0.0,<45.0.0 | |||
| state: present | |||
| - name: pyOpenSSL | |||
| - name: boto | |||
| - name: boto3 | |||
There was a problem hiding this comment.
RHEL/CentOS 7 won't have Python 3 installed and boto3 now only supports Python 3. Could you please pin to version 1.17.112 when using RHEL/CentOS 7?
|
@jsmcnair are you planning on addressing the feedback in the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably a bit of an edge case, but I noticed an issue when using this role.
To replicate the issue, you would have to have a playbook that delegates a task to localhost once the plays in this role have completed. I was getting a permission denied on the path to the python in the virtualenv, presumably because it doesn't exist on localhost.
The fix is to flag that the interpreter has been changed and revert to the 'discovered' python interpreter at the end of the plays in the role.