Refactored logging statements to use lazy % formatting #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhaibmujahid
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Thank you, @skynette! Could you please fix the test errors?
To avoid lint failures, it is recommended to setup pre-commit: https://github.com/mozilla/bugbug#auto-formatting
|
Okay I will attend to these thanks for feedback |
Co-authored-by: Suhaib Mujahid <[email protected]>
marco-c
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored most if not all logging statements to use % lazy format.
The goal of this PR is to refactor some of the logging statements to use the % lazy style of formatting
for example refactoring
logger.info(f"Fetching {events_url}")
becomes
logger.info("Analyzing {}...".format(bug_fixing_commit["rev"]))
This PR is part of the fix for #3323.