Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging statements to use lazy % formatting #3323

Closed
suhaibmujahid opened this issue Mar 6, 2023 · 6 comments · Fixed by #3326, #3335 or #3401
Closed

Refactor logging statements to use lazy % formatting #3323

suhaibmujahid opened this issue Mar 6, 2023 · 6 comments · Fixed by #3326, #3335 or #3401
Labels
good-first-bug Good for newcomers

Comments

@suhaibmujahid
Copy link
Member

suhaibmujahid commented Mar 6, 2023

Example of logging statements that we want to refactor:

logger.info(f"Fetching {events_url}")

logger.info("Analyzing {}...".format(bug_fixing_commit["rev"]))

More details can be found in the pylint docs.

@suhaibmujahid suhaibmujahid added the good-first-bug Good for newcomers label Mar 6, 2023
@WhiteWolf47
Copy link
Contributor

@suhaibmujahid I would like to help out and work on this issue, would you please assign this to me 😊

@suhaibmujahid
Copy link
Member Author

@suhaibmujahid I would like to help out and work on this issue, would you please assign this to me 😊

You can work on any issue which is open and has no PR linked to it.

Did you read #1092 or CONTRIBUTING.md?

@WhiteWolf47
Copy link
Contributor

@suhaibmujahid I would like to help out and work on this issue, would you please assign this to me blush

You can work on any issue which is open and has no PR linked to it.

Did you read #1092 or CONTRIBUTING.md?

yes I did

@suhaibmujahid
Copy link
Member Author

The target is to refactor all cases. Most of the cases still need to be refactored.

@KhadijaKamran
Copy link

Hi @suhaibmujahid, are there any cases still left or is this issue fixed?

@marco-c marco-c changed the title Refactor logging statemnts to use lazy % formatting Refactor logging statements to use lazy % formatting Mar 9, 2023
@suhaibmujahid
Copy link
Member Author

Hi @suhaibmujahid, are there any cases still left or is this issue fixed?

I still see one case:

LOGGER.info(f"Metrics saved to {file_path!r}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-bug Good for newcomers
Projects
None yet
3 participants