-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored some logging statements to use lazy % formatting #3326
Conversation
@suhaibmujahid can you please review this? 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of #3323 is to refactor all cases. However, you do not need to refactor all of them yourself. Will close #3323 when there are no more cases left.
BTW. This pull request is not linked to an issue. See here how to link a pull request to an issue: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
@WhiteWolf47 I think resolving #3323 is not your goal. Could you please update the description to mention that this pull request is part of the fix for #3323? Also, could you reflect the goal of the pull request in the description? The description mentions |
Will do that! |
@suhaibmujahid what you say now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please discard unrelated cahnges (the deleted lines at the end of .gitignore
and scripts/regressor_finder.py
)?
Also, please fix the lint errors. To avoid lint failures, it is recommended to setup |
…pre-commit install
@suhaibmujahid i've setup the pre-commit , still the lint error is there 🤔 . Also the pre-commit tests are passing perfectly normal in my local repo |
pre-commit runs on the new changes only. If the change is already committed, it will ignore it, but the CI will fail. To run pre-commit on everything, please run |
okay lemme try this! |
@suhaibmujahid "hook id : black" this one has failed, everything else has passed. But running "pre-commit run --all-files" again passes everything. |
@suhaibmujahid can you review this now, all checks have passed 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you, @WhiteWolf47!
No problem man. Thanks for helping me out with the issue. Looking forward to more contributions to bugbug 😃 |
@suhaibmujahid did the recommended changes, can you please review and merge now 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Refactored some logging statements in bugbug/scripts/regressor_finder.py
to use % lazy format.
This PR is part of the fix for #3323 .
This goal of this PR is to refactor some of the logging statements in bugbug/scripts/regressor_finder.py to use the % lazy style of formatting
for example : refactoring this statement -> logger.info("Analyzing {}...".format(bug_fixing_commit["rev"]))
to logger.info("Analyzing %s...", bug_fixing_commit["rev"])