Feat/permit bundler #178
Merged
Feat/permit bundler #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested changes
Sep 19, 2023
Rubilmax
requested changes
Sep 20, 2023
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Yes this is the next step ! |
Rubilmax
requested changes
Sep 20, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Signed-off-by: Jean-Grimal <[email protected]>
…ack into feat/permitBundler
Rubilmax
approved these changes
Sep 20, 2023
Rubilmax
requested changes
Sep 20, 2023
Rubilmax
requested changes
Sep 20, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
…ack into feat/permitBundler
Rubilmax
requested changes
Sep 21, 2023
There was a problem hiding this comment.
You can also remove the aToken specific implementation of permit since permit function is more general
(migration bundler can inherit from Permit bundler)
MerlinEgalite
requested changes
Sep 21, 2023
MerlinEgalite
approved these changes
Sep 21, 2023
Rubilmax
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.