Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the possibility to use Permit of an ERC20 #168

Closed
MerlinEgalite opened this issue Sep 13, 2023 · 1 comment · Fixed by #178
Closed

Add the possibility to use Permit of an ERC20 #168

MerlinEgalite opened this issue Sep 13, 2023 · 1 comment · Fixed by #178
Assignees
@Jean-Grimal

Comments

@MerlinEgalite
Copy link
Contributor

No description provided.

@Rubilmax
Copy link
Collaborator

Reference: https://eips.ethereum.org/EIPS/eip-2612

Let's name such an action permit

I'd argue that using permit2 in place of simplePermit2 would cost too much for permit2-based signature approvals while the UX can be greatly improved (1 less infinite approval to Permit2) by just switching actions from approve2 to permit when the token implements EIP2612

Btw, do you have examples of tokens implementing EIP2612?

@Rubilmax Rubilmax linked a pull request Sep 21, 2023 that will close this issue
Feat/permit bundler #178
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jean-Grimal Jean-Grimal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/permit bundler morpho-org/morpho-blue-bundlers
3 participants
@Rubilmax @MerlinEgalite @Jean-Grimal