Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-222001: Move pkg/utils under internal #1316

Merged
merged 1 commit into from
Jan 12, 2024
Merged

CLOUDP-222001: Move pkg/utils under internal #1316

merged 1 commit into from
Jan 12, 2024

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Jan 10, 2024 •
edited by gssbzn
Loading

All Submissions:

CLOUDP-222001

  • Have you signed our CLA?

@josvazg josvazg changed the title Cloudp 222001/move utils CLOUDP-222001: Move pkg/utils under internal Jan 10, 2024
s-urbaniak
s-urbaniak approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍾

@josvazg josvazg changed the base branch from main to CLOUDP-221195/move-testutil January 10, 2024 16:27
@josvazg josvazg marked this pull request as draft January 10, 2024 16:27
Base automatically changed from CLOUDP-221195/move-testutil to main January 11, 2024 12:05
@josvazg josvazg marked this pull request as ready for review January 11, 2024 15:21
@github-actions GitHub Actions
Copy link
Contributor

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/c54821870154c5a78d7b031c366ba4bcf4d61dde

gssbzn
gssbzn reviewed Jan 12, 2024
View reviewed changes
internal/toptr/toptr.go
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you use this one a lot in the CLI which means you going to have a hard time with the update there

@josvazg josvazg added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit aca8f35 Jan 12, 2024
44 of 49 checks passed
@josvazg josvazg deleted the CLOUDP-222001/move-utils branch January 12, 2024 13:17
@josvazg josvazg mentioned this pull request Jan 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn left review comments

@helderjs helderjs helderjs approved these changes

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@roothorp roothorp roothorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@josvazg @helderjs @s-urbaniak @gssbzn @igor-karpukhin @roothorp