Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-222001: Migrate to CLI's own pointer helper #2551

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Jan 12, 2024

Proposed changes

Due to mongodb/mongodb-atlas-kubernetes#1316 the pointer API there will not be available to consumers. This change moves the Kubernetes code not to rely on that soon disappearing API and instead use the local pointer helper available in the CLI already.

There seem to be no more code affected by the above PR:

% grep -r mongodb-atlas-kubernetes/pkg/util                         
grep: bin/atlas: binary file matches
% grep -r mongodb-atlas-kubernetes/v2/pkg/util
%

Jira ticket: CLOUDP-222001

Checklist

@josvazg josvazg requested review from helderjs, s-urbaniak, gssbzn and a team January 12, 2024 14:34
Copy link
Contributor

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@josvazg josvazg merged commit cd2b194 into master Jan 12, 2024
20 checks passed
@josvazg josvazg deleted the CLOUDP-222001/test-refactored-ako branch January 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants