Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-192060: Avoid recreate IPAccessList every reconciliation #1121

Merged
merged 1 commit into from
Sep 7, 2023
Merged

CLOUDP-192060: Avoid recreate IPAccessList every reconciliation #1121

merged 1 commit into from
Sep 7, 2023

Conversation

helderjs
Copy link
Collaborator

@helderjs helderjs commented Sep 7, 2023

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/4825e631cd7159fe6a067a00c48135c0faf3dac0

igor-karpukhin
igor-karpukhin reviewed Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if CIDRBlock is verified (see comment)

pkg/controller/atlasproject/ipaccess_list.go Show resolved Hide resolved
igor-karpukhin
igor-karpukhin approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helderjs helderjs merged commit c6db48f into main Sep 7, 2023
40 checks passed
@helderjs helderjs deleted the CLOUDP-192060-ip-access-list branch September 7, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@roothorp roothorp Awaiting requested review from roothorp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helderjs @igor-karpukhin