refactor reconciliation flow to avoid unneeded recreation

pkg/controller/atlas/ip_access_list.go

@@ -0,0 +1,33 @@
+package atlas
+
+import (
+	"context"
+	"fmt"
+	"net/http"
+
+	"go.mongodb.org/atlas/mongodbatlas"
+)
+
+type IPAccessListStatus func(ctx context.Context, projectID, entryValue string) (string, error)
+
+func CustomIPAccessListStatus(client *mongodbatlas.Client) IPAccessListStatus {
+	type ipAccessListStatus struct {
+		Status string `json:"STATUS"`
+	}
+
+	return func(ctx context.Context, projectID, entryValue string) (string, error) {
+		urlStr := fmt.Sprintf("/api/atlas/v1.0/groups/%s/accessList/%s/status", projectID, entryValue)
+		req, err := client.NewRequest(context.Background(), http.MethodGet, urlStr, nil)
+		if err != nil {
+			return "", err
+		}
+
+		status := ipAccessListStatus{}
+		_, err = client.Do(context.Background(), req, &status)
+		if err != nil {
+			return "", err
+		}
+
+		return status.Status, nil
+	}
+}

pkg/controller/atlasproject/atlasproject_controller.go

@@ -279,7 +279,7 @@ func (r *AtlasProjectReconciler) ensureProjectResources(ctx context.Context, wor
 	}
 
 	var result workflow.Result
-	if result = ensureIPAccessList(ctx, workflowCtx, project, r.SubObjectDeletionProtection); result.IsOk() {
+	if result = ensureIPAccessList(ctx, workflowCtx, atlas.CustomIPAccessListStatus(&workflowCtx.Client), project, r.SubObjectDeletionProtection); result.IsOk() {
 		r.EventRecorder.Event(project, "Normal", string(status.IPAccessListReadyType), "")
 	}
 	results = append(results, result)