-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-175080: Support deletion protection for Atlas projects #1028
CLOUDP-175080: Support deletion protection for Atlas projects #1028
Conversation
LGTM overall |
221aa71
to
d44d490
Compare
abe00cf
to
3e18e79
Compare
d44d490
to
06af725
Compare
3e18e79
to
286217c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍 Looks good in general!
testProject := &mdbv1.AtlasProject{} | ||
projectName := fmt.Sprintf("existing-project-%s", testNamespace.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: this can be moved the the BeforeEach
_, err := atlasClient.Projects.Delete(context.TODO(), projectID) | ||
Expect(err).To(BeNil()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: this can be moved to AfterEach
* Add deletion protection flags to manager and support in database_user controller (#1003) * CLOUDP-175080: Support deletion protection for Atlas projects (#1028) * Disable and hide deletion protection (#1052) Signed-off-by: Jose Vazquez <[email protected]> --------- Signed-off-by: Jose Vazquez <[email protected]> Co-authored-by: Helder Santana <[email protected]>
All Submissions:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if there is one).