CLOUDP-175080: Support deletion protection for Atlas projects #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
reviewed
Jul 5, 2023
josvazg
reviewed
Jul 5, 2023
|
LGTM overall |
josvazg
force-pushed
the
deletion-protection-main
branch
from
221aa71
to
d44d490
Compare
helderjs
force-pushed
the
CLOUDP-175080-project-deletion-protection
branch
2 times, most recently
from
abe00cf
to
3e18e79
Compare
josvazg
approved these changes
Jul 13, 2023
josvazg
force-pushed
the
deletion-protection-main
branch
from
d44d490
to
06af725
Compare
helderjs
force-pushed
the
CLOUDP-175080-project-deletion-protection
branch
from
3e18e79
to
286217c
Compare
igor-karpukhin
approved these changes
Jul 14, 2023
Comment on lines
+77
to
+78
| testProject := &mdbv1.AtlasProject{} | ||
| projectName := fmt.Sprintf("existing-project-%s", testNamespace.Name) |
There was a problem hiding this comment.
non-blocking: this can be moved the the BeforeEach
Comment on lines
+113
to
+114
| _, err := atlasClient.Projects.Delete(context.TODO(), projectID) | ||
| Expect(err).To(BeNil()) |
There was a problem hiding this comment.
non-blocking: this can be moved to AfterEach
3 tasks
helderjs
added a commit
that referenced
this pull request
Jul 26, 2023
josvazg
pushed a commit
that referenced
this pull request
Aug 2, 2023
josvazg
added a commit
that referenced
this pull request
Aug 2, 2023
* Add deletion protection flags to manager and support in database_user controller (#1003) * CLOUDP-175080: Support deletion protection for Atlas projects (#1028) * Disable and hide deletion protection (#1052) Signed-off-by: Jose Vazquez <[email protected]> --------- Signed-off-by: Jose Vazquez <[email protected]> Co-authored-by: Helder Santana <[email protected]>
josvazg
pushed a commit
that referenced
this pull request
Aug 2, 2023
helderjs
added a commit
that referenced
this pull request
Aug 2, 2023
helderjs
added a commit
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).