CLOUDP-178754: Deletion Protection for Data Federation #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
reviewed
Jul 24, 2023
pkg/controller/atlasdatafederation/datafederation_controller.go
Outdated
Show resolved
Hide resolved
josvazg
approved these changes
Jul 24, 2023
helderjs
force-pushed
the
deletion-protection-main
branch
from
5e6978c
to
510ca16
Compare
roothorp
force-pushed
the
cloudp-178754-deletion-protection-datafederation
branch
from
17ff66e
to
bdb1bf4
Compare
josvazg
reviewed
Jul 31, 2023
pkg/controller/atlasdatafederation/datafederation_controller.go
Outdated
Show resolved
Hide resolved
helderjs
requested changes
Jul 31, 2023
pkg/controller/atlasdatafederation/datafederation_controller.go
Outdated
Show resolved
Hide resolved
pkg/controller/atlasdatafederation/datafederation_controller.go
Outdated
Show resolved
Hide resolved
helderjs
requested changes
Aug 1, 2023
pkg/controller/atlasdatafederation/datafederation_controller.go
Outdated
Show resolved
Hide resolved
josvazg
force-pushed
the
deletion-protection-main
branch
from
c2253bd
to
9da259e
Compare
roothorp
force-pushed
the
cloudp-178754-deletion-protection-datafederation
branch
from
384727b
to
e64418c
Compare
helderjs
requested changes
Aug 7, 2023
Comment on lines
224
to
229
| return ctrl.NewControllerManagedBy(mgr). | ||
| Named("AtlasDataFederation"). | ||
| For(&mdbv1.AtlasDataFederation{}, builder.WithPredicates(r.GlobalPredicates...)). | ||
| Complete(r) |
There was a problem hiding this comment.
We need to revert this or properly handle the delete event. There's a cleanup step which doesn't execute with this configuration. This line in the old code is responsible for keeping it in the flow.
err = c.Watch(&source.Kind{Type: &mdbv1.AtlasDataFederation{}}, &watch.EventHandlerWithDelete{Controller: r}, r.GlobalPredicates...)There was a problem hiding this comment.
I think we can use Watches() which looks to be the same as For(), but you can specify the event.
roothorp
force-pushed
the
cloudp-178754-deletion-protection-datafederation
branch
from
b472b40
to
d19614d
Compare
helderjs
reviewed
Aug 10, 2023
| return nil | ||
| return ctrl.NewControllerManagedBy(mgr). | ||
| Named("AtlasDataFederation"). | ||
| Watches(&source.Kind{Type: &mdbv1.AtlasDataFederation{}}, &watch.EventHandlerWithDelete{Controller: r}, builder.WithPredicates(r.GlobalPredicates...)). |
There was a problem hiding this comment.
This looks very strange to me, but it does the same as before using the builder interface. We should visit this later.
helderjs
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).