-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-3002 Add download-mongodb capabilities to mongodl #522
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
037ad0a
add download-mongodb capabilities to mongodl
blink1073 0c4e188
fix tasks
blink1073 c9e60e9
fix tasks
blink1073 7a3c1a5
fix tests
blink1073 2c2137b
cleanup
blink1073 59fd23c
cleanup
blink1073 5afa224
fix test
blink1073 55c2414
expand tests
blink1073 311f3d7
update tests
blink1073 03f2739
update tests
blink1073 2b5186f
set python binary on rhel7
blink1073 5330236
fix usage of ensure_python3
blink1073 3bba8c2
fix usage of ensure_python3
blink1073 13eae99
skip mongodl for rhel7
blink1073 702026a
skip EOL pythons
blink1073 4ef561e
try again
blink1073 184a118
fix handling of 8.0
blink1073 1af7e57
Add perf version handling
blink1073 4c961d9
Add perf version handling
blink1073 51ee307
update versions
blink1073 70af6f5
address review
blink1073 3ced9db
check all supported versions
blink1073 26b8f3c
update tests
blink1073 f0db63e
fix macos handling
blink1073 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove 8.0.1-rc0 but add 7.0.15-rc1? Shouldn't we either ignore rc's altogether or update them consistently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking for the latest of each type, 8.0.1 went final. Perhaps we need to add a
--pre
flag for whether to allow prereleases?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I misread this as going from 8.0.1-rc0 -> 8.0.0. The current behavior of automatically using rc's seems fine to me. It has the potential to make us catch issues faster.