-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-3002 Add download-mongodb capabilities to mongodl #522
Conversation
VERSION_80="8.0.1-rc0" | ||
VERSION_70="7.0.14" | ||
VERSION_80="8.0.1" | ||
VERSION_70="7.0.15-rc1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove 8.0.1-rc0 but add 7.0.15-rc1? Shouldn't we either ignore rc's altogether or update them consistently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking for the latest of each type, 8.0.1 went final. Perhaps we need to add a --pre
flag for whether to allow prereleases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I misread this as going from 8.0.1-rc0 -> 8.0.0. The current behavior of automatically using rc's seems fine to me. It has the potential to make us catch issues faster.
Are the EVG test failures expected? |
|
Fixed, I was missing some supported versions. I made the list more prominent as a global. |
OIDC failure is unrelated, I'm configuring the EKS cluster. |
@ShaneHarvey I made a few changes since your last review. |
This is the first step in DRIVERS-3002.
This PR adds the following capabilities for parity with download-mongodb.sh:
The next PR will create a mongosh-dl.py to handle finding the mongosh download link.
The final PR will use mongodl.py and mongosh-dl.py directly in download-mongodb.sh.