Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-3002 Add download-mongodb capabilities to mongodl #522

Merged
merged 24 commits into from
Oct 15, 2024

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 8, 2024

This is the first step in DRIVERS-3002.
This PR adds the following capabilities for parity with download-mongodb.sh:

  • Handle named versions (8.0, etc)
  • Handle "rapid" version
  • Add support for perf versions
  • Normalize the handling of rhel downloads
  • Add option to just print the url
  • Add option to download the debug version of a server

The next PR will create a mongosh-dl.py to handle finding the mongosh download link.
The final PR will use mongodl.py and mongosh-dl.py directly in download-mongodb.sh.

@blink1073 blink1073 requested a review from ShaneHarvey October 8, 2024 15:44
.evergreen/config.yml Outdated Show resolved Hide resolved
@blink1073 blink1073 requested a review from ShaneHarvey October 14, 2024 18:35
VERSION_80="8.0.1-rc0"
VERSION_70="7.0.14"
VERSION_80="8.0.1"
VERSION_70="7.0.15-rc1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove 8.0.1-rc0 but add 7.0.15-rc1? Shouldn't we either ignore rc's altogether or update them consistently?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking for the latest of each type, 8.0.1 went final. Perhaps we need to add a --pre flag for whether to allow prereleases?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I misread this as going from 8.0.1-rc0 -> 8.0.0. The current behavior of automatically using rc's seems fine to me. It has the potential to make us catch issues faster.

@blink1073 blink1073 requested a review from ShaneHarvey October 14, 2024 22:08
@ShaneHarvey
Copy link
Contributor

Are the EVG test failures expected?

@ShaneHarvey
Copy link
Contributor

[2024/10/14 12:15:31.039] Download archive-debug 4.4-enterprise for windows-x86_64
[2024/10/14 12:15:31.039] Traceback (most recent call last):
[2024/10/14 12:15:31.039]   File "C:\data\mci\4886a0beacf64d962089348f95c465c9\drivers-tools\.evergreen\mongodl.py", line 1105, in <module>
[2024/10/14 12:15:31.042]     sys.exit(main(sys.argv[1:]))
[2024/10/14 12:15:31.042]              ^^^^^^^^^^^^^^^^^^
[2024/10/14 12:15:31.042]   File "C:\data\mci\4886a0beacf64d962089348f95c465c9\drivers-tools\.evergreen\mongodl.py", line 1087, in main
[2024/10/14 12:15:31.042]     result = _dl_component(cache,
[2024/10/14 12:15:31.042]              ^^^^^^^^^^^^^^^^^^^^
[2024/10/14 12:15:31.042]   File "C:\data\mci\4886a0beacf64d962089348f95c465c9\drivers-tools\.evergreen\mongodl.py", line 792, in _dl_component
[2024/10/14 12:15:31.042]     dl_url = _published_build_url(cache, version, target, arch, edition,
[2024/10/14 12:15:31.042]              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[2024/10/14 12:15:31.042]   File "C:\data\mci\4886a0beacf64d962089348f95c465c9\drivers-tools\.evergreen\mongodl.py", line 725, in _published_build_url
[2024/10/14 12:15:31.042]     raise ValueError(
[2024/10/14 12:15:31.042] ValueError: No download was found for version="4.4" target="windows" arch="x86_64" edition="enterprise" component="archive"
[2024/10/14 12:15:31.077] Command 'shell.exec' in function 'run mongodl test full' (step 1 of 1) failed: shell script encountered problem: exit code 1.

https://spruce.mongodb.com/task/drivers_tools_tests_all__os_fully_featured~windows_auth~auth_ssl~nossl_test_mongodl_full_patch_1edd98fc47a539910aff0802ac498bfe1072e214_670d645c6092660007ad1016_24_10_14_18_35_11/logs?execution=0&sortBy=STATUS&sortDir=ASC

@ShaneHarvey ShaneHarvey self-requested a review October 14, 2024 22:30
@blink1073
Copy link
Member Author

blink1073 commented Oct 15, 2024

Fixed, I was missing some supported versions. I made the list more prominent as a global.

@blink1073
Copy link
Member Author

OIDC failure is unrelated, I'm configuring the EKS cluster.

@blink1073
Copy link
Member Author

@ShaneHarvey I made a few changes since your last review.

@blink1073 blink1073 merged commit 9142b70 into mongodb-labs:master Oct 15, 2024
60 of 62 checks passed
@blink1073 blink1073 deleted the enhanced-mongodl branch October 15, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants