-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stlib] String conversion of list literals and lists with representable items #3521
Open
msaelices
wants to merge
11
commits into
modular:main
Choose a base branch
from
msaelices:representable-list-literals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5afc51a
[stlib] String conversion of list literals.
msaelices f825a10
Merge branch 'nightly' into representable-list-literals
msaelices 0065160
[stdlib] Test emojis representation
msaelices f597678
[stdlib] Add changelog entry
msaelices d556524
[stdlib] Remove non-used import
msaelices 7b705a2
[stdlib] Fix typo
msaelices 1eb2318
[stdlib] Conversion list of repr items as string via str()
msaelices edcdd44
Merge branch 'nightly' into representable-list-literals
msaelices f836400
[stdlib] Hack to workaround a overload resolution issue in compiler w…
msaelices bf08a77
Merge branch 'nightly' into representable-list-literals
msaelices 88e8a67
Merge branch 'nightly' into representable-list-literals
msaelices File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,10 @@ from testing import assert_equal | |
|
||
|
||
def test_str_none(): | ||
assert_equal(str(None), "None") | ||
# TODO(#3393): Change to str(None) when MLIR types do not confuse overload resolution. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question Is this still valid since we have |
||
# The error we are receiving with str(None) is: | ||
# cannot bind MLIR type 'None' to trait 'RepresentableCollectionElement' | ||
assert_equal(str(NoneType()), "None") | ||
|
||
|
||
def main(): | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackos would this sort of thing able to be improved with your in-flight PR for writer? I don't love explicitly enumerating a bunch of types that we know are convertible to writable since we just store a
Tuple[*Ts]
and don't know if theTs
are writable themselves.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need Mojo properly condicional conformance support, or at least to have a
_implements()
logic (see #3630) to be able to make this work without enumerating a bunch of types. This is the only workaround I know, and this is also used by @martinvuyk in theDType.get_type()
implementation (see #3810)