[stlib] String conversion of list literals and lists with representable items #3521
Conversation
To improve the ergonomics of the Mojo language for Python developers. Signed-off-by: Manuel Saelices <[email protected]>
Signed-off-by: Manuel Saelices <[email protected]>
Signed-off-by: Manuel Saelices <[email protected]>
Signed-off-by: Manuel Saelices <[email protected]>
Signed-off-by: Manuel Saelices <[email protected]>
msaelices
changed the title
Signed-off-by: Manuel Saelices <[email protected]>
msaelices
changed the title
…ith MLIR types Signed-off-by: Manuel Saelices <[email protected]>
msaelices
force-pushed
the
representable-list-literals
branch
from
cc5f8aa to
f836400
Compare
| @@ -16,7 +16,10 @@ from testing import assert_equal | |||
|
|
|||
|
|
|||
| def test_str_none(): | |||
| assert_equal(str(None), "None") | |||
| # TODO(#3393): Change to str(None) when MLIR types do not confuse overload resolution. | |||
There was a problem hiding this comment.
Question Is this still valid since we have NoneType in the stdlib now? We could give the conformance of RepresentableCollectionElement to it and the previous code may "just work"?
| writer.write(", ") | ||
|
|
||
| @parameter | ||
| if _type_is_eq[T, PythonObject](): |
There was a problem hiding this comment.
@jackos would this sort of thing able to be improved with your in-flight PR for writer? I don't love explicitly enumerating a bunch of types that we know are convertible to writable since we just store a Tuple[*Ts] and don't know if the Ts are writable themselves.
There was a problem hiding this comment.
I believe we need Mojo properly condicional conformance support, or at least to have a _implements() logic (see #3630) to be able to make this work without enumerating a bunch of types. This is the only workaround I know, and this is also used by @martinvuyk in the DType.get_type() implementation (see #3810)
To improve the ergonomics of the Mojo language for Python developers: