Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proto field to support a global image failsafe #1790

Merged
merged 2 commits into from
May 3, 2024
Merged

Add proto field to support a global image failsafe #1790

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a79b01
Add proto field to support a global image failsafe
mwaskom May 3, 2024
a8645ee
Rename field
mwaskom May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modal_proto/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,6 +1285,8 @@ message ImageGetOrCreateRequest {
bool force_build = 7;
DeploymentNamespace namespace = 8;
string builder_version = 9;
// Only admins can publish global images, but this provides an extra failsafe
bool global_deployment_allowed = 10;
mwaskom marked this conversation as resolved.
Show resolved Hide resolved
}

message ImageGetOrCreateResponse {
Expand Down
Loading