Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto field to support a global image failsafe #1790

Merged

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented May 3, 2024

Part of MOD-2866

  • Client+Server: this change is compatible with old servers
    - [ ] Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

modal_proto/api.proto Outdated Show resolved Hide resolved
@mwaskom
Copy link
Contributor Author

mwaskom commented May 3, 2024

@prbot automerge

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some required workflows are pending. Will automerge once they complete successfully. Please bear with us in this difficult time.

@modal-pr-review-automation modal-pr-review-automation bot merged commit 4d03618 into main May 3, 2024
22 checks passed
@modal-pr-review-automation modal-pr-review-automation bot deleted the michael/global-image-failsafe-proto branch May 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants