Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn stub->app pending deprecation warnings into non-pending #1779

Merged
merged 1 commit into from
May 13, 2024

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented May 1, 2024

Raising it one slight notch.

It will be months until we can make it errors though

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@erikbern erikbern force-pushed the erikbern/stub-app-pending-depr-warning branch from 23acadd to 07c6d18 Compare May 3, 2024 22:18
@erikbern erikbern merged commit ebc18a3 into main May 13, 2024
22 checks passed
@erikbern erikbern deleted the erikbern/stub-app-pending-depr-warning branch May 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant