turn stub->app pending deprecation warnings into non-pending

modal-labs · May 1, 2024 · 23acadd · 23acadd
1 parent 247c739
commit 23acadd
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/modal/app.py b/modal/app.py
@@ -831,7 +831,6 @@ def __new__(cls, *args, **kwargs):
             (2024, 4, 29),
             "The use of \"Stub\" has been deprecated in favor of \"App\"."
             " This is a pure name change with no other implications.",
-            pending=True
         )
         return _App(*args, **kwargs)
 

diff --git a/modal/cli/import_refs.py b/modal/cli/import_refs.py
@@ -125,7 +125,6 @@ def get_by_object_path_try_possible_app_names(obj: Any, obj_path: Optional[str])
                 (2024, 5, 1),
                 "The symbol `app` is not present but `stub` is. This will not work in future"
                 " Modal versions. Suggestion: change the name of `stub` to `app`.",
-                pending=True
             )
             return stub
         else:

diff --git a/modal/runner.py b/modal/runner.py
@@ -516,12 +516,12 @@ async def _interactive_shell(_app: _App, cmd: List[str], environment_name: str =
 
 
 def _run_stub(*args, **kwargs):
-    deprecation_warning((2024, 5, 1), "`run_stub` is deprecated. Please use `run_app` instead.", pending=True)
+    deprecation_warning((2024, 5, 1), "`run_stub` is deprecated. Please use `run_app` instead.")
     return _run_app(*args, **kwargs)
 
 
 def _deploy_stub(*args, **kwargs):
-    deprecation_warning((2024, 5, 1), "`deploy_stub` is deprecated. Please use `deploy_app` instead.", pending=True)
+    deprecation_warning((2024, 5, 1), "`deploy_stub` is deprecated. Please use `deploy_app` instead.")
     return _deploy_app(*args, **kwargs)
 
 

diff --git a/modal/serving.py b/modal/serving.py
@@ -129,7 +129,7 @@ async def _serve_app(
 
 
 def _serve_stub(*args, **kwargs):
-    deprecation_warning((2024, 5, 1), "`serve_stub` is deprecated. Please use `serve_app` instead.", pending=True)
+    deprecation_warning((2024, 5, 1), "`serve_stub` is deprecated. Please use `serve_app` instead.")
     return _run_app(*args, **kwargs)