Loosen the version of serde in Cargo.toml files
#380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the serde version was requiring a minimum patch version. This was more constraining for consumers of the crates than necessary. Now the `Cargo.toml` files only specify the Major.Minor version numbers for serde.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
github-actions
bot
added
size/XS
|
Test failure is due to, mobilecoinfoundation/actions#5 |
nick-mobilecoin
requested review from
eranrund and
dolanbernard
and removed request for
a team
eranrund
approved these changes
Jul 26, 2023
Codecov Report
@@ Coverage Diff @@
## nick/deserialize-vec-quote #380 +/- ##
===========================================================
Coverage 88.14% 88.14%
===========================================================
Files 40 40
Lines 5527 5527
===========================================================
Hits 4872 4872
Misses 655 655 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the serde version was requiring a minimum patch version. This
was more constraining for consumers of the crates than necessary. Now
the
Cargo.tomlfiles only specify the Major.Minor version numbers forserde.
Motivation
This was requiring the main MobileCoin repo to be n'sync with the newest version of serde these crates new about.
Future Work
When time permits it would be good to have a CI run that does a build with the
-Z minimum-versionsflag to ensure the minimum versions are specified correctly