Skip to content

Commit

Permalink
Loosen the version of serde in Cargo.toml files (#380)
Browse files Browse the repository at this point in the history
Previously the serde version was requiring a minimum patch version. This
was more constraining for consumers of the crates than necessary. Now
the `Cargo.toml` files only specify the Major.Minor version numbers for
serde.

### Motivation

This was requiring the main [MobileCoin
repo](https://github.com/mobilecoinfoundation/mobilecoin) to be n'sync
with the newest version of serde these crates new about.

### Future Work

When time permits it would be good to have a CI run that does a build
with the `-Z minimum-versions` flag to ensure the minimum versions are
specified correctly
  • Loading branch information
nick-mobilecoin authored Jul 27, 2023
2 parents bbb7534 + 01529e8 commit 33a5eac
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion capable/types/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ displaydoc = { version = "0.2.3", default-features = false }
mc-sgx-capable-sys-types = { path = "../sys/types", version = "=0.7.2" }
mc-sgx-core-types = { path = "../../core/types", version = "=0.7.2" }
mc-sgx-util = { path = "../../util", version = "=0.7.2" }
serde = { version = "1.0.173", default-features = false, features = ["derive"] }
serde = { version = "1.0", default-features = false, features = ["derive"] }

[dev-dependencies]
yare = "1.0.1"
2 changes: 1 addition & 1 deletion core/types/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ mc-sgx-core-sys-types = { path = "../sys/types", version = "=0.7.2" }
mc-sgx-util = { path = "../../util", version = "=0.7.2" }
nom = { version = "7.1.2", default-features = false }
rand_core = { version = "0.6.4", default-features = false }
serde = { version = "1.0.173", default-features = false, features = ["derive"] }
serde = { version = "1.0", default-features = false, features = ["derive"] }

# `getrandom` is pulled in by `rand_core` we only need to access it directly when registering a custom spng,
# `register_custom_getrandom`, which only happens for target_os = none
Expand Down
2 changes: 1 addition & 1 deletion dcap/types/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ mc-sgx-dcap-sys-types = { path = "../sys/types", version = "=0.7.2" }
mc-sgx-util = { path = "../../util", version = "=0.7.2" }
nom = { version = "7.1.2", default-features = false }
p256 = { version = "0.13.0", default-features = false, features = ["ecdsa-core", "ecdsa"] }
serde = { version = "1.0.173", default-features = false, features = ["derive"] }
serde = { version = "1.0", default-features = false, features = ["derive"] }
sha2 = { version = "0.10.6", default-features = false }
static_assertions = "1.1.0"
subtle = { version = "2.4.1", default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion tservice/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ mc-sgx-tservice-sys = { path = "sys", version = "=0.7.2" }
mc-sgx-tservice-sys-types = { path = "sys/types", version = "=0.7.2" }
mc-sgx-tservice-types = { path = "types", version = "=0.7.2", features = [ "alloc" ] }
mc-sgx-util = { path = "../util", version = "=0.7.2" }
serde = { version = "1.0.173", default-features = false, features = ["derive", "alloc"] }
serde = { version = "1.0", default-features = false, features = ["derive", "alloc"] }

[dev-dependencies]
mc-sgx-tservice-types = { path = "types", version = "=0.7.2", features = [ "test-utils" ] }
Expand Down

0 comments on commit 33a5eac

Please sign in to comment.