-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gromet] Updates Gromet to v0.1.10 and adds dependency generation #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/skema into vraymond/library_alignment
vincentraymond-ua
changed the title
Vraymond/library alignment
[gromet] Updates Gromet to v0.1.10 and adds dependency_depth field
Feb 26, 2024
vincentraymond-ua
changed the title
[gromet] Updates Gromet to v0.1.10 and adds dependency_depth field
[gromet] Updates Gromet to v0.1.10 and adds dependency generation
Feb 26, 2024
vincentraymond-ua
added
Code2FN
Backlog
Issue associated with a previous sprint that has not been completed
enhancement
New feature or request
lang/Python
Used for work related to Python (ex. frontend support)
and removed
Backlog
Issue associated with a previous sprint that has not been completed
labels
Feb 26, 2024
titomeister
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks Vincent!
github-actions
bot
removed
the
lang/Python
Used for work related to Python (ex. frontend support)
label
Feb 27, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 28, 2024
## Summary of Changes ### Updates Gromet FN to v0.1.10 - Adds GrometFNModuleDependencyReference type - Adds module_dependencies field to GrometFNModulecollection - Adds module_locate script to automatically extract and locate Python dependencies - Updates `multi_file_ingester` to support generating GrometFNModuleDependencyReferences - Adds post processing to module_dependencies field to remove duplicates and subpackages ### Adds dependency_depth flag - Adds new CLI argument `dependency_depth` to code2fn frontends and endpoints. - Currently supports values 0 and 1 - Adds support for ingesting .tar.gz files to `url_ingester` ### Bug fixes and testing - Fixes bug in module index dot notation generation - Adds test cases for dependency_depth field ### Related issues Resolves #790 Resolves #791 Resolves #798 Resolves #797 0e9320c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updates Gromet FN to v0.1.10
multi_file_ingester
to support generating GrometFNModuleDependencyReferencesAdds dependency_depth flag
dependency_depth
to code2fn frontends and endpoints.url_ingester
Bug fixes and testing
Related issues
Resolves #790
Resolves #791
Resolves #798
Resolves #797