Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unstable ut in leader_vew_manager.go file #39161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jan 10, 2025

issue: #38672

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@jaime0815 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@chyezh
Copy link
Contributor

chyezh commented Jan 10, 2025

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 10, 2025

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (826b726) to head (125d382).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39161      +/-   ##
==========================================
- Coverage   81.16%   81.15%   -0.01%     
==========================================
  Files        1395     1395              
  Lines      197277   197276       -1     
==========================================
- Hits       160124   160105      -19     
- Misses      31539    31558      +19     
+ Partials     5614     5613       -1     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.64% <ø> (ø)
Go 83.09% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/querycoordv2/meta/leader_view_manager.go 93.57% <100.00%> (-0.03%) ⬇️

... and 39 files with indirect coverage changes

sre-ci-robot pushed a commit that referenced this pull request Jan 10, 2025
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 11, 2025

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants