Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unstable ut in leader_vew_manager.go file #39162

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jan 10, 2025

issue: #38672
pr: #39161

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
@chyezh
Copy link
Contributor

chyezh commented Jan 10, 2025

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 10, 2025

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (a43720f) to head (6cece25).
Report is 1 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39162      +/-   ##
==========================================
- Coverage   81.06%   81.06%   -0.01%     
==========================================
  Files        1389     1389              
  Lines      196350   196349       -1     
==========================================
- Hits       159175   159174       -1     
  Misses      31569    31569              
  Partials     5606     5606              
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.55% <ø> (ø)
Go 83.03% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/querycoordv2/meta/leader_view_manager.go 93.57% <100.00%> (-0.03%) ⬇️

... and 25 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 10, 2025
@sre-ci-robot sre-ci-robot merged commit b0afe32 into milvus-io:2.5 Jan 10, 2025
19 of 20 checks passed
@jaime0815 jaime0815 deleted the fix-unstable-ut-25 branch January 11, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants