Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Discord.Discord version 1.0.9144 #157519

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Fix: Discord.Discord version 1.0.9144 #157519

merged 6 commits into from
Jun 17, 2024

Conversation

seangibbz
Copy link
Contributor

@seangibbz seangibbz commented Jun 12, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • [Y] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [Y] This PR only modifies one (1) manifest
  • [Y] Have you validated your manifest locally with winget validate --manifest <path>?
  • [Y] Have you tested your manifest locally with winget install --manifest <path>?
  • [Y] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

1 similar comment
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Forbidden-URL-Error labels Jun 12, 2024
@wingetbot
Copy link
Collaborator

Url validation error

3 similar comments
@wingetbot
Copy link
Collaborator

Url validation error

@wingetbot
Copy link
Collaborator

Url validation error

@wingetbot
Copy link
Collaborator

Url validation error

stephengillie
stephengillie requested changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /hc/en-us usually indicates that the developer is using the ZenDesk Help Center, and unfortunately they've blocked our automated scans.

manifests/d/Discord/Discord/1.0.9144/Discord.Discord.locale.en-US.yaml Outdated Show resolved Hide resolved
manifests/d/Discord/Discord/1.0.9144/Discord.Discord.locale.en-US.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jun 12, 2024
This was referenced Jun 12, 2024
Closed
Merged
@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 13, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jun 13, 2024
@wingetbot
Copy link
Collaborator

Url validation error

2 similar comments
@wingetbot
Copy link
Collaborator

Url validation error

@wingetbot
Copy link
Collaborator

Url validation error

@stephengillie
Copy link
Collaborator

#157519 (review)

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Forbidden-URL-Error labels Jun 15, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

seangibbz
seangibbz commented Jun 15, 2024
View reviewed changes
Copy link
Contributor Author

@seangibbz seangibbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hc urls removed

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 15, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

seangibbz,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit c003a91 into microsoft:master Jun 17, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 17, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@seangibbz seangibbz deleted the discord_9144 branch July 14, 2024 21:32
This was referenced Aug 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seangibbz @wingetbot @stephengillie