Discord.Discord 1.0.9057 and disable upgrades #167897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stevenlele
changed the title
wingetbot
added
New-Manifest
Azure-Pipeline-Passed
stephengillie
approved these changes
Aug 16, 2024
microsoft-github-policy-service
bot
added
the
Moderator-Approved
![microsoft-github-policy-service[bot]](https://avatars.githubusercontent.com/in/95686?s=60&v=4){kind=small}
microsoft-github-policy-service
bot
merged commit d779697
into
microsoft:master
8 checks passed
|
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
stevenlele
deleted the
Discord.Discord-1.0.9057-210B0F154AFB4166A9CBFCE7CC65471A
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally posted by @R-Adrian in microsoft/winget-cli#3482 (comment)
Added the flags back in this PR:
UpgradeBehavior: deny- because Discord "will break/override the user preferences and forcefully enable auto-start on system boot"RequireExplicitUpgrade: true- because Discord "does not update the version number in the registry"The flags were initially removed in #157519 without discussion. They were removed for x86 since 1.0.9053 (#165945) probably because that manifest was based on the x64 version.
See also:
Microsoft Reviewers: Open in CodeFlow