-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: block cell nav events w internal focus queue active #6754
Conversation
Will this also target the archive-fast-elemene-v1 branch? Otherwise the fast-blazor repo can't use it... |
Any update on @vnbaaij comment? Is anything more needed before this can be merged? |
Working with @vnbaaij on a Blazor solution that won't require porting something back, hopefully get some progress on that this weekend. JS authors can pretty easily work around this in their own implementations by catching the same events from their internal queues as this PR does, this change should make their lives easier though. Blazor authors are more constrained. |
Any update on this PR @scomea? |
Just pinged the collaborators to get some movement on reviews. |
499101a
to
fd2f1dd
Compare
* block cell nav events * Change files * better default focus fn * update to lates
📖 Description
Keyboard events emitted from a data grid cell when a cell's internal navigation is active can incorrectly move focus in the parent grid. Rather than rely on authors to intercept these events the cell component can prevent their propagation.
Additionally, this change adds
📑 Test Plan
Current tests all work
✅ Checklist
General
$ yarn change
Component-specific