Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: I can not use arrow keys in FluentTextArea inside a FluentDataGrid #418

Closed
Ogglas opened this issue Jun 1, 2023 · 8 comments · Fixed by #421
Closed

fix: I can not use arrow keys in FluentTextArea inside a FluentDataGrid #418

Ogglas opened this issue Jun 1, 2023 · 8 comments · Fixed by #421
Labels
bug A bug status:blocked Any issue blocked by another

Comments

@Ogglas
Copy link
Contributor

Ogglas commented Jun 1, 2023

🐛 Bug Report

I can not use arrow keys in FluentTextArea inside a FluentDataGrid. It works perfectly outside a FluentDataGrid

💻 Repro or Code Sample

<FluentDataGrid RowsData="@people">
    <TemplateColumn Title="TextArea">
        <FluentTextArea @bind-Value=value1></FluentTextArea>
    </TemplateColumn>
</FluentDataGrid>

@code {
    string value1;

    record Person(int PersonId, string Name, DateOnly BirthDate);

    IQueryable<Person> people = new[]
    {
        new Person(10895, "Jean Martin", new DateOnly(1985, 3, 16)),
        new Person(10944, "António Langa", new DateOnly(1991, 12, 1)),
        new Person(11203, "Julie Smith", new DateOnly(1958, 10, 10)),
    }.AsQueryable();
}
@vnbaaij vnbaaij added bug A bug status:blocked Any issue blocked by another labels Jun 1, 2023
@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 1, 2023

Hi, this one has already been raised to the FAST team: microsoft/fast#6500

@Ogglas
Copy link
Contributor Author

Ogglas commented Jun 1, 2023

I hope it will be fixed soon then! Did you get a change to look at the sort of related #217?

vnbaaij added a commit that referenced this issue Jun 1, 2023
@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 1, 2023

Oooh, I actually got a fix for this!! Can fix it outside of web-components script (with help from former FAST team member). Will now look #217 again...

vnbaaij added a commit that referenced this issue Jun 1, 2023
@vnbaaij vnbaaij mentioned this issue Jun 1, 2023
@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 1, 2023

Will be fixed with next release. Please verify it works here: https://calm-sea-053fa6a03-421.westeurope.3.azurestaticapps.net/DataGrid#template-columns-2

vnbaaij added a commit that referenced this issue Jun 2, 2023
* Fix #418

* Add a ccs class to enable grid to show multiple lines of text. Partialy fix #419
vnbaaij added a commit that referenced this issue Jun 4, 2023
* Fix #418

* Add a ccs class to enable grid to show multiple lines of text. Partialy fix #419
vnbaaij added a commit that referenced this issue Jun 4, 2023
* Fix #418

* Partialy fix #419 Add a ccs class to enable grid to show multiple lines of text.

* Fix #424: Infinite rendering loop in TableOfContents

* Fix #422 Demo site not working on iPhone
@Ogglas
Copy link
Contributor Author

Ogglas commented Jun 5, 2023

@vnbaaij Nice! However it only seems to be partially fixed. Using a virtualized data grid it still does not work. Example:

<FluentDataGrid RowsData="@people" Virtualize="true" RowsDataSize="100">
    <TemplateColumn Title="TextArea">
        <FluentTextArea @bind-Value=value1></FluentTextArea>
    </TemplateColumn>
</FluentDataGrid>

@code {
    string value1;

    record Person(int PersonId, string Name, DateOnly BirthDate);

    IQueryable<Person> people = new[]
    {
        new Person(10895, "Jean Martin", new DateOnly(1985, 3, 16)),
        new Person(10944, "António Langa", new DateOnly(1991, 12, 1)),
        new Person(11203, "Julie Smith", new DateOnly(1958, 10, 10)),
    }.AsQueryable();
}

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 5, 2023

Yes, confirmed it does not work with a virtualized grid. No idea how to fix that though...

Tried a number of things but with the Virtualize the javascript does not see the rows in the grid reference in the init method

@Ogglas
Copy link
Contributor Author

Ogglas commented Jun 5, 2023

Thanks anyway! Created a new issue to track the bug: #435

Can FAST solve it on their side?

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 6, 2023

A fix had just been submitted for this: microsoft/fast#6754. We have to get it in the right branch and pushed to the Fluent script and then test it, so might still take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug status:blocked Any issue blocked by another
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants