-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare nmdc-schema
as a Python dependency
#297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I left one comment, which was about adding a description to the click
command's help text.
Co-authored-by: eecavanna <[email protected]>
I locally resolved the merge conflicts. However once they were resolved the project's virtual environment became uninstallable:
This project's |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for your needs as well as just being easier to maintain. Thanks.
This is related to #258. Part of that task will be generating a new enum in
submission-schema
based on an enum innmdc-schema
plus some business logic. These changes will make it easier to accomplish that. Plus, they address the large number of places thenmdc-schema
version number needs to be changed when upgrading currently.The main idea here is to declare
nmdc-schema
as a normal Python dependency in thedev
Poetry group. All build steps that requirenmdc-schema
as a YAML file on disk now uselocal/nmdc.yaml
. This file in turn is extracted from the Python package by a small script instead of being fetched from GitHub.Updating the version of
nmdc-schema
used by the build process is now a matter of doing a normal Python dependency update, as noted in the README.