Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix process events handler #1969

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix process events handler #1969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions impress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ const loadApplications = async () => {
}
};

const stop = async (code = 0) => {
const stop = async (signal = 'SIGINT', code = 0) => {
const portsClosed = new Promise((resolve) => {
impress.console.info('Graceful shutdown in worker 0');
const timeout = setTimeout(() => {
Expand All @@ -214,7 +214,7 @@ const stop = async (code = 0) => {
broadcast(app, { name: 'stop' });
}
await portsClosed;
exit('Application server stopped', code);
exit(`Application server stopped by ${signal}`, code);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exit(`Application server stopped by ${signal}`, code);
exit(`Application server stopped by ${signal} with code ${code}`, code);

};

process.removeAllListeners('warning');
Expand Down
Loading