Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process events handler #1969

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

timursevimli
Copy link
Member

#1968

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

@@ -214,7 +214,7 @@ const stop = async (code = 0) => {
broadcast(app, { name: 'stop' });
}
await portsClosed;
exit('Application server stopped', code);
exit(`Application server stopped by ${signal}`, code);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exit(`Application server stopped by ${signal}`, code);
exit(`Application server stopped by ${signal} with code ${code}`, code);

@tshemsedinov tshemsedinov merged commit 2549a72 into metarhia:master May 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants