Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A large CircleCI VM can able to handle 4 test jobs #1245

Merged
merged 2 commits into from
Sep 2, 2024
Merged

A large CircleCI VM can able to handle 4 test jobs #1245

merged 2 commits into from
Sep 2, 2024

Conversation

oalders
Copy link
Member

@oalders oalders commented Sep 2, 2024 •
edited
Loading

This PR:

  • reduces the CircleCI build time by ~10%
  • simplifies the CircleCI config by using an official Orb rather than deprecated code

@oalders
A large CircleCI VM can able to handle 4 test jobs
32fc80d 
rather than 2. Possibly we could run more in parallel. Might be worth
experimenting with.

Devel::Cover::Report::Codecovbash was not being used

Use codecov orb for report upload

Don't wait for ES until we absolutely have to
@oalders
Don't chown report
fb035bb
ranguard
ranguard approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@ranguard ranguard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find having name after what it's doing a bit odd.. I want to read what it's mean to be doing and then how it's doing it... but that's how it was before

@oalders oalders merged commit 70b2432 into master Sep 2, 2024
1 check passed
@oalders oalders deleted the oalders/more-test-jobs branch September 2, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranguard ranguard ranguard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oalders @ranguard