Skip to content

Commit

Permalink
Don't wait for ES until we absolutely have to
Browse files Browse the repository at this point in the history
  • Loading branch information
oalders committed Sep 2, 2024
1 parent ca2d0ce commit debb21a
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,6 @@ jobs:
./bin/metacpan-docker init
docker-compose --verbose up -d api_test
name: compose up
# Since we're running docker-compose -d, we don't actually know if
# Elasticsearch is available at the time this build step begins. We
# probably need to wait for it here, so we'll add our own check.
- run:
command: |
pushd metacpan-docker
./src/metacpan-api/wait-for-es.sh http://localhost:9200 elasticsearch_test --
name: wait for ES
# We are relying on environment variables from the host to be available when
# we publish the report, so we publish from the host rather than trying
# to propagate env variables to the container.
Expand All @@ -56,6 +48,14 @@ jobs:
pushd metacpan-docker
docker-compose exec -T api_test cpm install -g Devel::Cover
name: install Devel::Cover
# Since we're running docker-compose -d, we don't actually know if
# Elasticsearch is available at the time this build step begins. We
# probably need to wait for it here, so we'll add our own check.
- run:
command: |
pushd metacpan-docker
./src/metacpan-api/wait-for-es.sh http://localhost:9200 elasticsearch_test
name: wait for ES
- run:
command: |
pushd metacpan-docker
Expand Down

0 comments on commit debb21a

Please sign in to comment.