Support com.gradleup.shadow plugin
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
reviewed
Aug 21, 2024
Goooler
reviewed
Aug 21, 2024
Makes the [new shadow plugin ID](https://github.com/GradleUp/shadow/releases/tag/8.3.0) the default, reference `com.github.johnrengelman.shadow` as the "old" one, remove `io.github.goooler.shadow`. Includes renames of related functional tests.
Co-authored-by: Zongle Wang <[email protected]>
snazy
force-pushed
the
shadow-plugin-move
branch
from
cf6ed49 to
bcc0e97
Compare
|
🤦 just realized that the PR was based on an old commit - had to rebase |
Goooler
reviewed
Aug 21, 2024
Goooler
changed the title
com.gradleup.shadow plugin
Goooler
reviewed
Aug 22, 2024
src/funcTest/resources/java-project-with-feature-previews/build.gradle
Outdated
Show resolved
Hide resolved
…d.gradle Co-authored-by: Zongle Wang <[email protected]>
Goooler
approved these changes
Aug 25, 2024
src/funcTest/groovy/me/champeau/jmh/JmhWithShadowPluginSpec.groovy
Outdated
Show resolved
Hide resolved
Goooler
force-pushed
the
shadow-plugin-move
branch
from
3442315 to
907f9db
Compare
Goooler
reviewed
Aug 26, 2024
src/funcTest/groovy/me/champeau/jmh/JmhWithShadowPluginSpec.groovy
Outdated
Show resolved
Hide resolved
Goooler
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the new shadow plugin ID the default, reference
com.github.johnrengelman.shadowas the "old" one, removeio.github.goooler.shadow. Includes renames of related functional tests.