Support io.github.goooler.shadow plugin
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
approved these changes
Jan 5, 2024
gradle.properties
Outdated
| @@ -9,6 +9,7 @@ project_vcs=https://github.com/melix/jmh-gradle-plugin.git | |||
| jacocoVersion = 0.8.10 | |||
| jmhVersion = 1.37 | |||
| shadowVersion = 7.1.2 | |||
| shadowForkVersion = 8.1.2 | |||
There was a problem hiding this comment.
Suggested change
| shadowForkVersion = 8.1.2 | |
| shadowForkVersion = 8.1.3 |
There was a problem hiding this comment.
Ah, nice. 8.1.3 wasn't on Gradle Plugins when I opened the PR.
There was a problem hiding this comment.
Yeah, cause I unified this group to io.github.goooler.shadow and published it to MavenCentral.
melix
approved these changes
Jan 17, 2024
The shadow-plugin (ID `com.github.johnrengelman.shadow`) is currently rather unmaintained (last change in March/April 2023 as of January 2024) and already has a bunch of issues, especially with newer Gradle versions (8.2+) and when the included classes are built for Java 21 or newer (class file version 65+). This is problematic when using Java 21 directly or including a recent version of jackson-core, which is a multi-release jar that contains Java 21 classes. There is a fork of the shadow plugin (ID `io.github.goooler.shadow`) that works against newer Gradle versions and Java 21. That one however is not recognized by the jmh plugin, which only check against the "original" plugin ID. This change adds support for the forked plugin, one line change in the production code, other changes are readme and tests.
snazy
force-pushed
the
forked-shadow-plugin
branch
from
1f959b6 to
038daaf
Compare
|
rebased + fixed CI |
|
@melix do you know when there'll be a release with this change? |
|
@snazy Could you support the official update? We land it, see https://github.com/GradleUp/shadow/releases/tag/8.3.0 |
|
@Goooler on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shadow-plugin (ID
com.github.johnrengelman.shadow) is currently rather unmaintained (last change in March/April 2023 as of January 2024) and already has a bunch of issues, especially with newer Gradle versions (8.2+) and when the included classes are built for Java 21 or newer (class file version 65+). This is problematic when using Java 21 directly or including a recent version of jackson-core, which is a multi-release jar that contains Java 21 classes.There is a fork of the shadow plugin (ID
io.github.goooler.shadow) that works against newer Gradle versions and Java 21. That one however is not recognized by the jmh plugin, which only check against the "original" plugin ID.This change adds support for the forked plugin, one line change in the production code, other changes are readme and tests.