Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support data for Chrome Android (API's N through S) #18361

Closed
wants to merge 3 commits into from
Closed

Update support data for Chrome Android (API's N through S) #18361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6be923f
Update support data for Chrome Android (N through S)
jugglinmike Dec 2, 2022
b5c7f12
Override known-bad change
jugglinmike Dec 2, 2022
089ee25
Revert inaccurate changes
jugglinmike Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions api/OES_draw_buffers_indexed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
"chrome": {
"version_added": "100"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like a bunch of the EXT_* #18359 it's hard to judge if this is correct. Is the extension never supported on Android, or does it depend on the hardware?

I suggest breaking out WebGL stuff into separate PRs.

},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -39,7 +41,9 @@
"chrome": {
"version_added": "100"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -72,7 +76,9 @@
"chrome": {
"version_added": "100"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -105,7 +111,9 @@
"chrome": {
"version_added": "100"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -138,7 +146,9 @@
"chrome": {
"version_added": "100"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -171,7 +181,9 @@
"chrome": {
"version_added": "100"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -204,7 +216,9 @@
"chrome": {
"version_added": "100"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -237,7 +251,9 @@
"chrome": {
"version_added": "100"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down
4 changes: 3 additions & 1 deletion api/OES_texture_half_float_linear.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
"chrome": {
"version_added": "29"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment. (I can't find any bug about this.)

},
"edge": {
"version_added": "14"
},
Expand Down
6 changes: 4 additions & 2 deletions api/OVR_multiview2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"notes": "Not supported on macOS."
},
"chrome_android": {
"version_added": "93"
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment. I found https://bugs.chromium.org/p/chromium/issues/detail?id=906739 but can't find anything to suggest it's just disabled on Android.

},
"edge": "mirror",
"firefox": {
Expand Down Expand Up @@ -47,7 +47,9 @@
"chrome": {
"version_added": "93"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "71"
Expand Down
4 changes: 3 additions & 1 deletion api/OffscreenCanvasRenderingContext2D.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,9 @@
"chrome": {
"version_added": "69"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://mdn-bcd-collector.appspot.com/tests/api/OffscreenCanvasRenderingContext2D/commit shows no support in Chrome on macOS either.

This is actually behind a flag:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/runtime_enabled_features.json5;l=1927-1928;drc=65df527c2efd800e5e4e5113559c701938be8e88

So the desktop data above should be updated instead.

},
"edge": "mirror",
"firefox": {
"version_added": "105"
Expand Down
4 changes: 3 additions & 1 deletion api/Performance.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,9 @@
"chrome": {
"version_added": "89"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that this has [CrossOriginIsolated] in the IDL and the collector deployment presumably doesn't meet the requirements for this to be exposed.

I've filed foolip/mdn-bcd-collector#2656.

},
"deno": {
"version_added": false
},
Expand Down
16 changes: 12 additions & 4 deletions api/PushManager.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@
"chrome": {
"version_added": "42"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasPermission seems non-standard and actually not supported. With some more testing to confirm, I think this entry should be removed.

},
"edge": {
"version_added": "17"
},
Expand Down Expand Up @@ -217,7 +219,9 @@
"chrome": {
"version_added": "42"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": "17"
},
Expand Down Expand Up @@ -256,7 +260,9 @@
"chrome": {
"version_added": "42"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": "17"
},
Expand Down Expand Up @@ -392,7 +398,9 @@
"chrome": {
"version_added": "42"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": "17"
},
Expand Down
4 changes: 3 additions & 1 deletion api/PushSubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,9 @@
"chrome": {
"version_added": "42"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gone from Chromium:
https://bugs.chromium.org/p/chromium/issues/detail?id=477401#c5

That means the entry should be removed entirely, since it was more than 2 years ago.

},
"edge": {
"version_added": "≤18"
},
Expand Down
4 changes: 3 additions & 1 deletion api/RTCIceTransport.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@
"chrome": {
"version_added": "75"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no constructor in the spec or in Chromium:
https://w3c.github.io/webrtc-pc/#rtcicetransport
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl;drc=047c7dc4ee1ce908d7fea38ca063fa2f80f92c77

That means this entry should be removed.

},
"edge": {
"version_added": "13"
},
Expand Down
20 changes: 15 additions & 5 deletions api/Report.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
"chrome": {
"version_added": "69"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a [NoInterfaceObject] problem mentioned in https://github.com/mdn/browser-compat-data/pull/18359/files#r1061151206.

},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -41,7 +43,9 @@
"chrome": {
"version_added": "69"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -74,7 +78,9 @@
"chrome": {
"version_added": "69"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -108,7 +114,9 @@
"chrome": {
"version_added": "69"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -142,7 +150,9 @@
"chrome": {
"version_added": "69"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down
8 changes: 6 additions & 2 deletions api/ReportBody.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
"chrome": {
"version_added": "69"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a [NoInterfaceObject] problem mentioned in https://github.com/mdn/browser-compat-data/pull/18359/files#r1061151206.

},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down Expand Up @@ -40,7 +42,9 @@
"chrome": {
"version_added": "69"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false
Expand Down
4 changes: 3 additions & 1 deletion api/Request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,9 @@
"chrome": {
"version_added": "101"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no priority property on Request in the spec and the desktop data here is wrong. This entry should be removed.

},
"deno": {
"version_added": false
},
Expand Down
16 changes: 12 additions & 4 deletions api/SharedWorkerGlobalScope.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
"chrome": {
"version_added": "4"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": false
"version_added": false,
"notes": "See <a href='https://crbug.com/154571'>bug 154571</a>."

From #18575.

},
"edge": "mirror",
"firefox": {
"version_added": "29"
Expand Down Expand Up @@ -139,7 +141,9 @@
"chrome": {
"version_added": "4"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "29"
Expand Down Expand Up @@ -195,7 +199,9 @@
"chrome": {
"version_added": "4"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "29",
Expand Down Expand Up @@ -250,7 +256,9 @@
"chrome": {
"version_added": "4"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "29"
Expand Down
8 changes: 6 additions & 2 deletions api/SpeechGrammar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@
"chrome": {
"version_added": "25"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://mdn-bcd-collector.appspot.com/tests/api/SpeechGrammar shows no support on desktop too. Here the problem is that the interface object is prefixed in Chromium, as webkitSpeechGrammar.

None of the Speech* changes in this PR are likely to be correct for similar reasons.

I've started foolip/mdn-bcd-collector#2659 to fix the tests, but it's not done.

},
"edge": "mirror",
"firefox": {
"version_added": "44",
Expand Down Expand Up @@ -153,7 +155,9 @@
"chrome": {
"version_added": "25"
},
"chrome_android": "mirror",
"chrome_android": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "44",
Expand Down
Loading