-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update support data for Chrome Android (API's N through S) #18361
Conversation
These changes were generated procedurally by the mdn-bcd-collector project [1] using data collected from Chrome for Android [2]. [1] https://github.com/foolip/mdn-bcd-collector commit 06ea2714451c548934849011e4106b3175adfab5 [2] https://github.com/foolip/mdn-bcd-results commit f37e6db1da24143bf039ed8e269c9f234d2b4e90
The mdn-bcd-collector tool has a deficiency which cause it to produce incorrect changes for the Notification constructor. See "Testing constructors with no arguments misses some ways of disabling constructors": foolip/mdn-bcd-collector#970
Due to known issues in the tooling, the automatically-generated changes to `api/PermissionsPolicyViolationReportBody.json` were inaccurate and needed to be manually removed. mdn#17908 (comment)
@@ -7,7 +7,9 @@ | |||
"chrome": { | |||
"version_added": "100" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like a bunch of the EXT_* #18359 it's hard to judge if this is correct. Is the extension never supported on Android, or does it depend on the hardware?
I suggest breaking out WebGL stuff into separate PRs.
@@ -8,7 +8,9 @@ | |||
"chrome": { | |||
"version_added": "29" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment. (I can't find any bug about this.)
@@ -11,7 +11,7 @@ | |||
"notes": "Not supported on macOS." | |||
}, | |||
"chrome_android": { | |||
"version_added": "93" | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment. I found https://bugs.chromium.org/p/chromium/issues/detail?id=906739 but can't find anything to suggest it's just disabled on Android.
@@ -305,7 +305,9 @@ | |||
"chrome": { | |||
"version_added": "69" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://mdn-bcd-collector.appspot.com/tests/api/OffscreenCanvasRenderingContext2D/commit shows no support in Chrome on macOS either.
This is actually behind a flag:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/runtime_enabled_features.json5;l=1927-1928;drc=65df527c2efd800e5e4e5113559c701938be8e88
So the desktop data above should be updated instead.
@@ -686,7 +686,9 @@ | |||
"chrome": { | |||
"version_added": "89" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here is that this has [CrossOriginIsolated]
in the IDL and the collector deployment presumably doesn't meet the requirements for this to be exposed.
I've filed foolip/mdn-bcd-collector#2656.
@@ -8,7 +8,9 @@ | |||
"chrome": { | |||
"version_added": "69" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a [NoInterfaceObject]
problem mentioned in https://github.com/mdn/browser-compat-data/pull/18359/files#r1061151206.
@@ -8,7 +8,9 @@ | |||
"chrome": { | |||
"version_added": "69" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a [NoInterfaceObject]
problem mentioned in https://github.com/mdn/browser-compat-data/pull/18359/files#r1061151206.
@@ -1073,7 +1073,9 @@ | |||
"chrome": { | |||
"version_added": "101" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no priority
property on Request
in the spec and the desktop data here is wrong. This entry should be removed.
@@ -8,7 +8,9 @@ | |||
"chrome": { | |||
"version_added": "4" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version_added": false | |
"version_added": false, | |
"notes": "See <a href='https://crbug.com/154571'>bug 154571</a>." |
From #18575.
@@ -105,7 +105,9 @@ | |||
"chrome": { | |||
"version_added": "25" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://mdn-bcd-collector.appspot.com/tests/api/SpeechGrammar shows no support on desktop too. Here the problem is that the interface object is prefixed in Chromium, as webkitSpeechGrammar
.
None of the Speech* changes in this PR are likely to be correct for similar reasons.
I've started foolip/mdn-bcd-collector#2659 to fix the tests, but it's not done.
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
1 similar comment
This pull request has merge conflicts that must be resolved before it can be merged. |
Given how much iteration there has been on the collector project since this PR was opened (December 2022), I am going to close this. |
Summary
These changes were generated procedurally by the mdn-bcd-collector project [1] using data collected from Chrome for Android [2].
[1] https://github.com/foolip/mdn-bcd-collector
commit 06ea2714451c548934849011e4106b3175adfab5
[2] https://github.com/foolip/mdn-bcd-results
commit f37e6db1da24143bf039ed8e269c9f234d2b4e90
Test results and supporting details
Related issues
This changeset is based on the one originally submitted via #17908. It uses compatibility data which has been collected since that patch was created, and it includes only a subset of the changes generated by the mdn-bcd-collector.